From: Jeff Garzik <jeff@garzik•org>
To: Atsushi Nemoto <anemo@mba•ocn.ne.jp>
Cc: netdev@vger•kernel.org, David Miller <davem@davemloft•net>
Subject: Re: [PATCH] isa-skelton: Remove a wrong netif_wake_queue() call
Date: Fri, 26 Feb 2010 12:03:47 -0500 [thread overview]
Message-ID: <4B87FEF3.5020809@garzik.org> (raw)
In-Reply-To: <1267027217-7812-1-git-send-email-anemo@mba.ocn.ne.jp>
On 02/24/2010 11:00 AM, Atsushi Nemoto wrote:
> The netif_wake_queue() is called correctly (i.e. only on !txfull
> condition) from net_tx(). So Unconditional call to the
> netif_wake_queue() here is wrong. This might cause calling of
> start_xmit routine on txfull state and trigger tx-ring overflow.
>
> This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687.
>
> Signed-off-by: Atsushi Nemoto<anemo@mba•ocn.ne.jp>
> ---
> drivers/net/isa-skeleton.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/isa-skeleton.c b/drivers/net/isa-skeleton.c
> index 04d0502..3f33c90 100644
> --- a/drivers/net/isa-skeleton.c
> +++ b/drivers/net/isa-skeleton.c
> @@ -536,7 +536,6 @@ static irqreturn_t net_interrupt(int irq, void *dev_id)
> /* Transmit complete. */
> net_tx(dev);
> np->stats.tx_packets++;
> - netif_wake_queue(dev);
> }
> #endif
I would suggest deleting this "driver" entirely... Any new drivers
remotely like ISA would use the platform API and look more like a PCI
driver.
Jeff
prev parent reply other threads:[~2010-02-26 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 16:00 [PATCH] isa-skelton: Remove a wrong netif_wake_queue() call Atsushi Nemoto
2010-02-26 9:51 ` David Miller
2010-02-26 16:13 ` Atsushi Nemoto
2010-02-26 17:03 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B87FEF3.5020809@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=anemo@mba$(echo .)ocn.ne.jp \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox