From: David Miller <davem@davemloft•net>
To: herbert@gondor•apana.org.au
Cc: hadi@cyberus•ca, timo.teras@iki•fi, netdev@vger•kernel.org
Subject: Re: [PATCH 3/4] xfrm: remove policy lock when accessing policy->walk.dead
Date: Wed, 31 Mar 2010 13:52:39 -0700 (PDT) [thread overview]
Message-ID: <20100331.135239.170044408.davem@davemloft.net> (raw)
In-Reply-To: <20100331135331.GB14082@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor•apana.org.au>
Date: Wed, 31 Mar 2010 21:53:31 +0800
> Dave, please revert this patch.
Herbert I actually don't agree with you on this one, sorry :-)
If no semantic change occurred to the policy or state databases,
there is zero reason to report the flush event, it's noise.
Like Jamal, I too am pretty frustrated with how noisy and unusable the
netlink messages are to watch when trying to debug something and this
behavior change should break no applications whatsoever.
When you have evidence of a real existing case failing because of
Jamal's changes (not some case you crafted specifically to show that
an empty flush doesn't get reported), I'll consider a revert or ask
Jamal to fix that case up.
Until then, Jamal's change is staying in the tree.
next prev parent reply other threads:[~2010-03-31 20:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 10:17 [PATCH 0/4] xfrm fixes and flow structurization Timo Teras
2010-03-31 10:17 ` Timo Teras
2010-03-31 10:17 ` [PATCH 1/4] xfrm: increment genid before bumping state genids Timo Teras
2010-03-31 10:50 ` Herbert Xu
2010-03-31 10:55 ` Timo Teräs
2010-03-31 11:01 ` Timo Teräs
2010-03-31 11:19 ` Herbert Xu
2010-03-31 11:24 ` Timo Teräs
2010-03-31 10:17 ` [PATCH 2/4] xfrm_user: verify policy direction at XFRM_MSG_POLEXPIRE handler Timo Teras
2010-03-31 10:54 ` Herbert Xu
2010-03-31 10:17 ` [PATCH 3/4] xfrm: remove policy lock when accessing policy->walk.dead Timo Teras
2010-03-31 11:03 ` Herbert Xu
2010-03-31 13:06 ` jamal
2010-03-31 13:11 ` Herbert Xu
2010-03-31 13:26 ` Herbert Xu
2010-03-31 13:32 ` jamal
2010-03-31 13:39 ` jamal
2010-03-31 13:41 ` jamal
2010-03-31 13:56 ` Herbert Xu
2010-03-31 14:15 ` jamal
2010-03-31 20:54 ` David Miller
2010-03-31 13:55 ` Herbert Xu
2010-03-31 14:12 ` jamal
2010-03-31 14:15 ` Herbert Xu
2010-03-31 14:24 ` jamal
2010-03-31 14:29 ` Herbert Xu
2010-03-31 14:38 ` jamal
2010-03-31 20:57 ` David Miller
2010-04-01 0:22 ` Herbert Xu
2010-04-01 2:19 ` jamal
2010-04-01 10:53 ` jamal
2010-03-31 13:28 ` jamal
2010-03-31 13:53 ` Herbert Xu
2010-03-31 16:41 ` Patrick McHardy
2010-03-31 17:47 ` jamal
2010-04-01 11:24 ` Patrick McHardy
2010-03-31 20:52 ` David Miller [this message]
2010-03-31 10:17 ` [PATCH 4/4] flow: structurize flow cache Timo Teras
2010-03-31 11:21 ` Herbert Xu
2010-04-02 2:42 ` [PATCH 0/4] xfrm fixes and flow structurization David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331.135239.170044408.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=hadi@cyberus$(echo .)ca \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=timo.teras@iki$(echo .)fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox