From: Patrick McHardy <kaber@trash•net>
To: hadi@cyberus•ca
Cc: Herbert Xu <herbert@gondor•apana.org.au>,
Timo Teras <timo.teras@iki•fi>,
netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH 3/4] xfrm: remove policy lock when accessing policy->walk.dead
Date: Thu, 01 Apr 2010 13:24:25 +0200 [thread overview]
Message-ID: <4BB48269.7010307@trash.net> (raw)
In-Reply-To: <1270057677.26743.116.camel@bigi>
jamal wrote:
> On Wed, 2010-03-31 at 18:41 +0200, Patrick McHardy wrote:
>
>> I agree with Herbert, the flush notification indicates that
>> the table is now empty, independant of its previous state.
>
> What purpose does it serve?
>
> As an example, if i delete an entry, the fact i deleted an entry is
> of interest to some manager in user space for the purpose of syncing.
> If i brought a link down, same thing. If i brought a link down
> that was already down - why would that be of interest to generate
> as an event? etc.
That's true. Since both pfkey and xfrm process messages synchronously,
there shouldn't be any need for this. In fact I couldn't even find
a single keying daemon that cares about this message.
next prev parent reply other threads:[~2010-04-01 11:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 10:17 [PATCH 0/4] xfrm fixes and flow structurization Timo Teras
2010-03-31 10:17 ` Timo Teras
2010-03-31 10:17 ` [PATCH 1/4] xfrm: increment genid before bumping state genids Timo Teras
2010-03-31 10:50 ` Herbert Xu
2010-03-31 10:55 ` Timo Teräs
2010-03-31 11:01 ` Timo Teräs
2010-03-31 11:19 ` Herbert Xu
2010-03-31 11:24 ` Timo Teräs
2010-03-31 10:17 ` [PATCH 2/4] xfrm_user: verify policy direction at XFRM_MSG_POLEXPIRE handler Timo Teras
2010-03-31 10:54 ` Herbert Xu
2010-03-31 10:17 ` [PATCH 3/4] xfrm: remove policy lock when accessing policy->walk.dead Timo Teras
2010-03-31 11:03 ` Herbert Xu
2010-03-31 13:06 ` jamal
2010-03-31 13:11 ` Herbert Xu
2010-03-31 13:26 ` Herbert Xu
2010-03-31 13:32 ` jamal
2010-03-31 13:39 ` jamal
2010-03-31 13:41 ` jamal
2010-03-31 13:56 ` Herbert Xu
2010-03-31 14:15 ` jamal
2010-03-31 20:54 ` David Miller
2010-03-31 13:55 ` Herbert Xu
2010-03-31 14:12 ` jamal
2010-03-31 14:15 ` Herbert Xu
2010-03-31 14:24 ` jamal
2010-03-31 14:29 ` Herbert Xu
2010-03-31 14:38 ` jamal
2010-03-31 20:57 ` David Miller
2010-04-01 0:22 ` Herbert Xu
2010-04-01 2:19 ` jamal
2010-04-01 10:53 ` jamal
2010-03-31 13:28 ` jamal
2010-03-31 13:53 ` Herbert Xu
2010-03-31 16:41 ` Patrick McHardy
2010-03-31 17:47 ` jamal
2010-04-01 11:24 ` Patrick McHardy [this message]
2010-03-31 20:52 ` David Miller
2010-03-31 10:17 ` [PATCH 4/4] flow: structurize flow cache Timo Teras
2010-03-31 11:21 ` Herbert Xu
2010-04-02 2:42 ` [PATCH 0/4] xfrm fixes and flow structurization David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB48269.7010307@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=hadi@cyberus$(echo .)ca \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=timo.teras@iki$(echo .)fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox