From: Rusty Russell <rusty@rustcorp•com.au>
To: Taku Izumi <izumi.taku@jp•fujitsu.com>
Cc: "David S. Miller" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Michael S. Tsirkin" <mst@redhat•com>
Subject: Re: [PATCH] virtio_net: implements ethtool_ops.get_drvinfo
Date: Tue, 15 Jun 2010 13:58:11 +0930 [thread overview]
Message-ID: <201006151358.12071.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4C11915E.6090201@jp.fujitsu.com>
On Fri, 11 Jun 2010 10:59:02 am Taku Izumi wrote:
> This patch implements ethtool_ops.get_drvinfo interface of virtio_net driver.
>
> Signed-off-by: Taku Izumi <izumi.taku@jp•fujitsu.com>
Hi Taku!
Does this have any useful effect?
Thanks,
Rusty.
> ---
> drivers/net/virtio_net.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> Index: net-next.35/drivers/net/virtio_net.c
> ===================================================================
> --- net-next.35.orig/drivers/net/virtio_net.c
> +++ net-next.35/drivers/net/virtio_net.c
> @@ -701,6 +701,18 @@ static int virtnet_close(struct net_devi
> return 0;
> }
>
> +static void virtnet_get_drvinfo(struct net_device *dev,
> + struct ethtool_drvinfo *drvinfo)
> +{
> + struct virtnet_info *vi = netdev_priv(dev);
> + struct virtio_device *vdev = vi->vdev;
> +
> + strncpy(drvinfo->driver, KBUILD_MODNAME, 32);
> + strncpy(drvinfo->version, "N/A", 32);
> + strncpy(drvinfo->fw_version, "N/A", 32);
> + strncpy(drvinfo->bus_info, dev_name(&vdev->dev), 32);
> +}
> +
> static int virtnet_set_tx_csum(struct net_device *dev, u32 data)
> {
> struct virtnet_info *vi = netdev_priv(dev);
> @@ -813,6 +825,7 @@ static void virtnet_vlan_rx_kill_vid(str
> }
>
> static const struct ethtool_ops virtnet_ethtool_ops = {
> + .get_drvinfo = virtnet_get_drvinfo,
> .set_tx_csum = virtnet_set_tx_csum,
> .set_sg = ethtool_op_set_sg,
> .set_tso = ethtool_op_set_tso,
>
next prev parent reply other threads:[~2010-06-15 4:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 1:29 [PATCH] virtio_net: implements ethtool_ops.get_drvinfo Taku Izumi
2010-06-15 4:28 ` Rusty Russell [this message]
2010-06-15 5:20 ` Taku Izumi
2010-06-16 1:54 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2010-08-05 3:32 Rusty Russell
2010-08-05 3:47 ` Ben Hutchings
2010-08-05 4:54 ` David Miller
2010-08-06 15:59 ` Loke, Chetan
2010-08-06 16:15 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006151358.12071.rusty@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=davem@davemloft$(echo .)net \
--cc=izumi.taku@jp$(echo .)fujitsu.com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox