From: Taku Izumi <izumi.taku@jp•fujitsu.com>
To: Rusty Russell <rusty@rustcorp•com.au>
Cc: "David S. Miller" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Michael S. Tsirkin" <mst@redhat•com>
Subject: Re: [PATCH] virtio_net: implements ethtool_ops.get_drvinfo
Date: Tue, 15 Jun 2010 14:20:30 +0900 [thread overview]
Message-ID: <4C170D9E.5090407@jp.fujitsu.com> (raw)
In-Reply-To: <201006151358.12071.rusty@rustcorp.com.au>
Hi Rusty,
(2010/06/15 13:28), Rusty Russell wrote:
> On Fri, 11 Jun 2010 10:59:02 am Taku Izumi wrote:
>> This patch implements ethtool_ops.get_drvinfo interface of virtio_net driver.
>>
>> Signed-off-by: Taku Izumi<izumi.taku@jp•fujitsu.com>
>
> Hi Taku!
>
> Does this have any useful effect?
I often use "ethtool -i" command to check what driver controls the ehternet device.
But because current virtio_net driver doesn't support "ethtool -i", it becomes the
following:
# ethtool -i eth3
Cannot get driver information: Operation not supported
My patch simply adds the "ethtool -i" support. The following is the result when
using the virtio_net driver with my patch applied to.
# ethtool -i eth3
driver: virtio_net
version: N/A
firmware-version: N/A
bus-info: virtio0
Personally, "-i" is one of the most frequently-used option, and
most network drivers support "ethtool -i", so I think virtio_net also should do.
Taku Izumi <izumi.taku@jp•fujitsu.com>
next prev parent reply other threads:[~2010-06-15 5:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 1:29 [PATCH] virtio_net: implements ethtool_ops.get_drvinfo Taku Izumi
2010-06-15 4:28 ` Rusty Russell
2010-06-15 5:20 ` Taku Izumi [this message]
2010-06-16 1:54 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2010-08-05 3:32 Rusty Russell
2010-08-05 3:47 ` Ben Hutchings
2010-08-05 4:54 ` David Miller
2010-08-06 15:59 ` Loke, Chetan
2010-08-06 16:15 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C170D9E.5090407@jp.fujitsu.com \
--to=izumi.taku@jp$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rusty@rustcorp$(echo .)com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox