public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, gospo@redhat•com, bphilips@novell•com,
	Alexander Duyck <alexander.h.duyck@intel•com>,
	Don Skidmore <donald.c.skidmore@intel•com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel•com>
Subject: [net-next-2.6 PATCH 2/5] ixgbe: drop support for UDP in RSS hash generation
Date: Mon, 19 Jul 2010 16:59:27 -0700	[thread overview]
Message-ID: <20100719235925.14112.65890.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100719235831.14112.14175.stgit@localhost.localdomain>

From: Alexander Duyck <alexander.h.duyck@intel•com>

This change removes UDP from the supported protocols for RSS hashing.  The
reason for removing this protocol is because IP fragmentation was causing a
network flow to be broken into two streams, one for fragmented, and one for
non-fragmented and this in turn was causing out-of-order issues.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel•com>
Acked-by: Don Skidmore <donald.c.skidmore@intel•com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
---

 drivers/net/ixgbe/ixgbe_main.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index b235aa1..813d2cb 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -2800,10 +2800,8 @@ static void ixgbe_configure_rx(struct ixgbe_adapter *adapter)
 		    /* Perform hash on these packet types */
 		mrqc |= IXGBE_MRQC_RSS_FIELD_IPV4
 		      | IXGBE_MRQC_RSS_FIELD_IPV4_TCP
-		      | IXGBE_MRQC_RSS_FIELD_IPV4_UDP
 		      | IXGBE_MRQC_RSS_FIELD_IPV6
-		      | IXGBE_MRQC_RSS_FIELD_IPV6_TCP
-		      | IXGBE_MRQC_RSS_FIELD_IPV6_UDP;
+		      | IXGBE_MRQC_RSS_FIELD_IPV6_TCP;
 	}
 	IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc);
 


  reply	other threads:[~2010-07-19 23:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 23:59 [net-next-2.6 PATCH 1/5] ixgbe: dcb, set DPF bit when PFC is enabled Jeff Kirsher
2010-07-19 23:59 ` Jeff Kirsher [this message]
2010-07-20  3:24   ` [net-next-2.6 PATCH 2/5] ixgbe: drop support for UDP in RSS hash generation David Miller
2010-07-20  6:07     ` Bill Fink
2010-07-20  6:30       ` Eric Dumazet
2010-07-20  6:39         ` David Miller
2010-07-20  6:39   ` Eric Dumazet
2010-07-20  6:44     ` David Miller
2010-07-20 16:11     ` Alexander Duyck
2010-07-20 16:39       ` Eric Dumazet
2010-07-19 23:59 ` [net-next-2.6 PATCH 3/5] ixgbe: properly toggling netdev feature flags when disabling FCoE Jeff Kirsher
2010-07-20  3:24   ` David Miller
2010-07-20  0:00 ` [net-next-2.6 PATCH 4/5] ixgbe: use GFP_ATOMIC when allocating FCoE DDP context from the dma pool Jeff Kirsher
2010-07-20  3:24   ` David Miller
2010-07-20  0:00 ` [net-next-2.6 PATCH 5/5] ixgbe: fix version string for ixgbe Jeff Kirsher
2010-07-20  3:24   ` David Miller
2010-07-20  3:24 ` [net-next-2.6 PATCH 1/5] ixgbe: dcb, set DPF bit when PFC is enabled David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100719235925.14112.65890.stgit@localhost.localdomain \
    --to=jeffrey.t.kirsher@intel$(echo .)com \
    --cc=alexander.h.duyck@intel$(echo .)com \
    --cc=bphilips@novell$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=donald.c.skidmore@intel$(echo .)com \
    --cc=gospo@redhat$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox