From: Bill Fink <billfink@mindspring•com>
To: David Miller <davem@davemloft•net>
Cc: jeffrey.t.kirsher@intel•com, netdev@vger•kernel.org,
gospo@redhat•com, bphilips@novell•com,
alexander.h.duyck@intel•com, donald.c.skidmore@intel•com
Subject: Re: [net-next-2.6 PATCH 2/5] ixgbe: drop support for UDP in RSS hash generation
Date: Tue, 20 Jul 2010 02:07:54 -0400 [thread overview]
Message-ID: <20100720020754.135b5ff7.billfink@mindspring.com> (raw)
In-Reply-To: <20100719.202417.218061462.davem@davemloft.net>
On Mon, 19 Jul 2010, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
> Date: Mon, 19 Jul 2010 16:59:27 -0700
>
> > From: Alexander Duyck <alexander.h.duyck@intel•com>
> >
> > This change removes UDP from the supported protocols for RSS hashing. The
> > reason for removing this protocol is because IP fragmentation was causing a
> > network flow to be broken into two streams, one for fragmented, and one for
> > non-fragmented and this in turn was causing out-of-order issues.
> >
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@intel•com>
> > Acked-by: Don Skidmore <donald.c.skidmore@intel•com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
>
> Applied.
Should there be a /proc or ethtool setting for whether or not to
use RSS hashing for UDP flows? I would think that for many common
UDP applications, IP fragmentation would not be an issue because
they often tend to use sub-MTU sized datagrams. And of course
UDP does not guarantee in-order delivery in any event. Then a
remaining issue is what the default setting of such an option
should be. I would lean to having it enabled by default, but
I can also see the safety argument for having it off by default.
-Bill
next prev parent reply other threads:[~2010-07-20 6:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 23:59 [net-next-2.6 PATCH 1/5] ixgbe: dcb, set DPF bit when PFC is enabled Jeff Kirsher
2010-07-19 23:59 ` [net-next-2.6 PATCH 2/5] ixgbe: drop support for UDP in RSS hash generation Jeff Kirsher
2010-07-20 3:24 ` David Miller
2010-07-20 6:07 ` Bill Fink [this message]
2010-07-20 6:30 ` Eric Dumazet
2010-07-20 6:39 ` David Miller
2010-07-20 6:39 ` Eric Dumazet
2010-07-20 6:44 ` David Miller
2010-07-20 16:11 ` Alexander Duyck
2010-07-20 16:39 ` Eric Dumazet
2010-07-19 23:59 ` [net-next-2.6 PATCH 3/5] ixgbe: properly toggling netdev feature flags when disabling FCoE Jeff Kirsher
2010-07-20 3:24 ` David Miller
2010-07-20 0:00 ` [net-next-2.6 PATCH 4/5] ixgbe: use GFP_ATOMIC when allocating FCoE DDP context from the dma pool Jeff Kirsher
2010-07-20 3:24 ` David Miller
2010-07-20 0:00 ` [net-next-2.6 PATCH 5/5] ixgbe: fix version string for ixgbe Jeff Kirsher
2010-07-20 3:24 ` David Miller
2010-07-20 3:24 ` [net-next-2.6 PATCH 1/5] ixgbe: dcb, set DPF bit when PFC is enabled David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720020754.135b5ff7.billfink@mindspring.com \
--to=billfink@mindspring$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=bphilips@novell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox