From: "Matt Carlson" <mcarlson@broadcom•com>
To: "Anton Blanchard" <anton@samba•org>
Cc: "Matthew Carlson" <mcarlson@broadcom•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"andy@greyhouse•net" <andy@greyhouse•net>,
"Michael Chan" <mchan@broadcom•com>
Subject: Re: [PATCH net-next 09/14] tg3: Improve small packet performance
Date: Wed, 4 Aug 2010 15:46:07 -0700 [thread overview]
Message-ID: <20100804224607.GA4881@mcarlson.broadcom.com> (raw)
In-Reply-To: <20100804222741.GA18708@kryten>
On Wed, Aug 04, 2010 at 03:27:41PM -0700, Anton Blanchard wrote:
>
> Hi,
>
> Just saw this go in:
>
> > static inline u32 tg3_tx_avail(struct tg3_napi *tnapi)
> > {
> > - smp_mb();
> > + /* Tell compiler to fetch tx indices from memory. */
> > + barrier();
> > return tnapi->tx_pending -
> > ((tnapi->tx_prod - tnapi->tx_cons) & (TG3_TX_RING_SIZE - 1));
> > }
>
> Which worries me. Are we sure we don't need any ordering (eg smp_rmb)?
> A compiler barrier does nothing to ensure two loads are ordered.
>
> Anton
The compiler barrier makes sure the loads stay roughly in the same
location. In the places where the ordering really matters, we have the
memory barrier inlined into the calling code. In the rest of the
places, we can relax the ordering requirement because the final value is
just used as an estimate.
next prev parent reply other threads:[~2010-08-04 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 21:26 [PATCH net-next 09/14] tg3: Improve small packet performance Matt Carlson
2010-08-04 22:27 ` Anton Blanchard
2010-08-04 22:46 ` Matt Carlson [this message]
2010-08-04 22:47 ` Michael Chan
2010-08-04 23:08 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804224607.GA4881@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=anton@samba$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox