From: "Matt Carlson" <mcarlson@broadcom•com>
To: "Micha?? Miros??aw" <mirq-linux@rere•qmqm.pl>
Cc: "linux-net-drivers@solarflare•com"
<linux-net-drivers@solarflare•com>,
Debashis Dutt <ddutt@brocade•com>,
"e1000-devel@lists•sourceforge.net"
<e1000-devel@lists•sourceforge.net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Greg Kroah-Hartman <gregkh@suse•de>,
Rasesh Mody <rmody@brocade•com>,
"linux-driver@qlogic•com" <linux-driver@qlogic•com>,
Steve Glendinning <steve.glendinning@smsc•com>,
Kristoffer Glembo <kristoffer@gaisler•com>
Subject: Re: [PATCH 2/4] Ethtool: convert get_sg/set_sg calls to hw_features flag
Date: Mon, 1 Nov 2010 19:24:38 -0700 [thread overview]
Message-ID: <20101102022438.GA4243@mcarlson.broadcom.com> (raw)
In-Reply-To: <9d89236b6e4ff8c66937fbd7d8ce76602e680c5b.1288496404.git.mirq-linux@rere.qmqm.pl>
On Fri, Oct 29, 2010 at 09:28:26PM -0700, Micha?? Miros??aw wrote:
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index 30ccbb6..b07e2d1 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -11306,7 +11306,6 @@ static const struct ethtool_ops tg3_ethtool_ops = {
> .get_rx_csum = tg3_get_rx_csum,
> .set_rx_csum = tg3_set_rx_csum,
> .set_tx_csum = tg3_set_tx_csum,
> - .set_sg = ethtool_op_set_sg,
> .set_tso = tg3_set_tso,
> .self_test = tg3_self_test,
> .get_strings = tg3_get_strings,
> @@ -14681,6 +14680,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
> tp->rx_pending = TG3_DEF_RX_RING_PENDING;
> tp->rx_jumbo_pending = TG3_DEF_RX_JUMBO_RING_PENDING;
>
> + dev->hw_features |= NETIF_F_SG;
Scatter-gather should not be enabled if TG3_FLAG_BROKEN_CHECKSUMS is set. I
would do the following instead:
if (!(tp->tg3_flags & TG3_FLAG_BROKEN_CHECKSUMS))
dev->hw_features |= NETIF_F_SG;
TG3_FLAG_BROKEN_CHECKSUMS is set in tg3_get_invariants(), so this code
would need to be placed later than that function call.
> dev->ethtool_ops = &tg3_ethtool_ops;
> dev->watchdog_timeo = TG3_TX_TIMEOUT;
> dev->irq = pdev->irq;
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists•sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2010-11-02 2:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 3:40 [PATCH 0/4] Ethtool: cleanup strategy Michał Mirosław
2010-10-30 4:27 ` [PATCH 1/4] Ethtool: Introduce hw_features field in struct netdevice Michał Mirosław
2010-10-30 4:28 ` [PATCH 2/4] Ethtool: convert get_sg/set_sg calls to hw_features flag Michał Mirosław
2010-11-01 21:15 ` Ben Hutchings
2010-11-02 0:59 ` Michał Mirosław
2010-11-02 2:24 ` Matt Carlson [this message]
2010-11-03 22:29 ` Micha?? Miros??aw
2010-11-03 22:42 ` Matt Carlson
2010-11-03 22:58 ` Michał Mirosław
2010-10-30 8:44 ` [PATCH 3/4] Ethtool: convert get_tso/set_tso calls to hw_features flags Michał Mirosław
2010-11-01 21:25 ` Ben Hutchings
2010-11-02 1:14 ` Michał Mirosław
2010-11-02 2:49 ` Matt Carlson
2010-10-31 0:09 ` [PATCH 4/4] Ethtool: convert get_tx_csum/set_tx_csum " Michał Mirosław
2010-11-01 21:38 ` Ben Hutchings
2010-11-02 1:23 ` Michał Mirosław
2010-10-31 4:18 ` [PATCH 0/4] Ethtool: cleanup strategy David Miller
2010-10-31 4:30 ` Michał Mirosław
2010-11-01 21:05 ` Ben Hutchings
2010-11-02 1:02 ` Michał Mirosław
2010-11-02 1:14 ` Ben Hutchings
2010-11-02 1:30 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102022438.GA4243@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=ddutt@brocade$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=gregkh@suse$(echo .)de \
--cc=kristoffer@gaisler$(echo .)com \
--cc=linux-driver@qlogic$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rmody@brocade$(echo .)com \
--cc=steve.glendinning@smsc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox