From: "Matt Carlson" <mcarlson@broadcom•com>
To: "Micha?? Miros??aw" <mirq-linux@rere•qmqm.pl>
Cc: "Matthew Carlson" <mcarlson@broadcom•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"e1000-devel@lists•sourceforge.net"
<e1000-devel@lists•sourceforge.net>,
"Steve Glendinning" <steve.glendinning@smsc•com>,
"Greg Kroah-Hartman" <gregkh@suse•de>,
"Rasesh Mody" <rmody@brocade•com>,
"Debashis Dutt" <ddutt@brocade•com>,
"Kristoffer Glembo" <kristoffer@gaisler•com>,
"linux-driver@qlogic•com" <linux-driver@qlogic•com>,
"linux-net-drivers@solarflare•com"
<linux-net-drivers@solarflare•com>
Subject: Re: [PATCH 2/4] Ethtool: convert get_sg/set_sg calls to hw_features flag
Date: Wed, 3 Nov 2010 15:42:47 -0700 [thread overview]
Message-ID: <20101103224247.GB9869@mcarlson.broadcom.com> (raw)
In-Reply-To: <20101103222910.GA24320@rere.qmqm.pl>
On Wed, Nov 03, 2010 at 03:29:10PM -0700, Micha?? Miros??aw wrote:
> On Mon, Nov 01, 2010 at 07:24:38PM -0700, Matt Carlson wrote:
> > On Fri, Oct 29, 2010 at 09:28:26PM -0700, Micha?? Miros??aw wrote:
> > > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> > > index 30ccbb6..b07e2d1 100644
> > > --- a/drivers/net/tg3.c
> > > +++ b/drivers/net/tg3.c
> > > @@ -11306,7 +11306,6 @@ static const struct ethtool_ops tg3_ethtool_ops = {
> > > .get_rx_csum = tg3_get_rx_csum,
> > > .set_rx_csum = tg3_set_rx_csum,
> > > .set_tx_csum = tg3_set_tx_csum,
> > > - .set_sg = ethtool_op_set_sg,
> > > .set_tso = tg3_set_tso,
> > > .self_test = tg3_self_test,
> > > .get_strings = tg3_get_strings,
> > > @@ -14681,6 +14680,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
> > > tp->rx_pending = TG3_DEF_RX_RING_PENDING;
> > > tp->rx_jumbo_pending = TG3_DEF_RX_JUMBO_RING_PENDING;
> > >
> > > + dev->hw_features |= NETIF_F_SG;
> > Scatter-gather should not be enabled if TG3_FLAG_BROKEN_CHECKSUMS is set. I
> > would do the following instead:
> >
> > if (!(tp->tg3_flags & TG3_FLAG_BROKEN_CHECKSUMS))
> > dev->hw_features |= NETIF_F_SG;
> >
> > TG3_FLAG_BROKEN_CHECKSUMS is set in tg3_get_invariants(), so this code
> > would need to be placed later than that function call.
>
> This bug is there now, so I'll queue this as all other hints of existent
> bugs that this patch series "uncovers".
How so? This patch would be introducing the bug. From tg3_get_invariants:
if (tp->pci_chip_rev_id == CHIPREV_ID_5700_B0)
tp->tg3_flags |= TG3_FLAG_BROKEN_CHECKSUMS;
else {
unsigned long features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_GRO;
tp->tg3_flags |= TG3_FLAG_RX_CHECKSUMS;
if (tp->tg3_flags3 & TG3_FLG3_5755_PLUS)
features |= NETIF_F_IPV6_CSUM;
tp->dev->features |= features;
vlan_features_add(tp->dev, features);
}
next prev parent reply other threads:[~2010-11-03 22:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 3:40 [PATCH 0/4] Ethtool: cleanup strategy Michał Mirosław
2010-10-30 4:27 ` [PATCH 1/4] Ethtool: Introduce hw_features field in struct netdevice Michał Mirosław
2010-10-30 4:28 ` [PATCH 2/4] Ethtool: convert get_sg/set_sg calls to hw_features flag Michał Mirosław
2010-11-01 21:15 ` Ben Hutchings
2010-11-02 0:59 ` Michał Mirosław
2010-11-02 2:24 ` Matt Carlson
2010-11-03 22:29 ` Micha?? Miros??aw
2010-11-03 22:42 ` Matt Carlson [this message]
2010-11-03 22:58 ` Michał Mirosław
2010-10-30 8:44 ` [PATCH 3/4] Ethtool: convert get_tso/set_tso calls to hw_features flags Michał Mirosław
2010-11-01 21:25 ` Ben Hutchings
2010-11-02 1:14 ` Michał Mirosław
2010-11-02 2:49 ` Matt Carlson
2010-10-31 0:09 ` [PATCH 4/4] Ethtool: convert get_tx_csum/set_tx_csum " Michał Mirosław
2010-11-01 21:38 ` Ben Hutchings
2010-11-02 1:23 ` Michał Mirosław
2010-10-31 4:18 ` [PATCH 0/4] Ethtool: cleanup strategy David Miller
2010-10-31 4:30 ` Michał Mirosław
2010-11-01 21:05 ` Ben Hutchings
2010-11-02 1:02 ` Michał Mirosław
2010-11-02 1:14 ` Ben Hutchings
2010-11-02 1:30 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103224247.GB9869@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=ddutt@brocade$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=gregkh@suse$(echo .)de \
--cc=kristoffer@gaisler$(echo .)com \
--cc=linux-driver@qlogic$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rmody@brocade$(echo .)com \
--cc=steve.glendinning@smsc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox