From: Casey Leedom <leedom@chelsio•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next-26 5/5] cxgb4vf: Mark "UDP [RSS Hash] Enable" as a 1-bit field.
Date: Mon, 15 Nov 2010 09:43:32 -0800 [thread overview]
Message-ID: <201011150943.32541.leedom@chelsio.com> (raw)
In-Reply-To: <20101115.092059.59691885.davem@davemloft.net>
| From: David Miller <davem@davemloft•net>
| Date: Monday, November 15, 2010 09:20 am
|
| From: Casey Leedom <leedom@chelsio•com>
| Date: Thu, 11 Nov 2010 11:30:44 -0800
|
| > + uint synmapen:1; /* SYN Map Enable */
|
| Please do not use the "uint" shorthand for "unsigned int", I know it's
| in linux/types.h but that is there for sysv compatibility in
| userspace and is ugly as hell.
Okay, sorry about that. I wasn't sure so I looked around and saw several
other network device drivers using "uint" and figured it was okay. I assume
that it's okay to use u32, etc? I was just trying to be neet and solve the
"greater than 80 column" restriction which the patch check script complains
about for when a previous changeset converted "int" to "unsigned int". Just let
me know what the correct action is and I'll respin this one patch. Thanks for
your patience with my ignorance!
Casey
prev parent reply other threads:[~2010-11-15 17:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 19:30 [PATCH net-next-26 0/5] cxgb4vf: minor cleanup Casey Leedom
2010-11-11 19:30 ` [PATCH net-next-26 1/5] cxgb4vf: minor comment/symbolic name cleanup Casey Leedom
2010-11-15 17:18 ` David Miller
2010-11-11 19:30 ` [PATCH net-next-26 2/5] cxgb4vf: add ethtool statistics for GRO Casey Leedom
2010-11-15 17:19 ` David Miller
2010-11-11 19:30 ` [PATCH net-next-26 3/5] cxgb4vf: fix up "Section Mismatch" compiler warning Casey Leedom
2010-11-15 17:19 ` David Miller
2010-11-11 19:30 ` [PATCH net-next-26 4/5] cxgb4vf: Advertise NETIF_F_TSO_ECN Casey Leedom
2010-11-15 17:19 ` David Miller
2010-11-11 19:30 ` [PATCH net-next-26 5/5] cxgb4vf: Mark "UDP [RSS Hash] Enable" as a 1-bit field Casey Leedom
2010-11-15 17:20 ` David Miller
2010-11-15 17:43 ` Casey Leedom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011150943.32541.leedom@chelsio.com \
--to=leedom@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox