From: "Matt Carlson" <mcarlson@broadcom•com>
To: "David Miller" <davem@davemloft•net>
Cc: "Matthew Carlson" <mcarlson@broadcom•com>,
"greg@kroah•com" <greg@kroah•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"stable@kernel•org" <stable@kernel•org>
Subject: Re: [stable] [PATCH net-2.6/stable] tg3: Restrict phy ioctl access
Date: Wed, 16 Feb 2011 16:39:47 -0800 [thread overview]
Message-ID: <20110217003947.GA11185@mcarlson.broadcom.com> (raw)
In-Reply-To: <20110216.161025.59672084.davem@davemloft.net>
On Wed, Feb 16, 2011 at 04:10:25PM -0800, David Miller wrote:
> From: "Matt Carlson" <mcarlson@broadcom•com>
> Date: Wed, 16 Feb 2011 15:52:48 -0800
>
> > On Wed, Feb 16, 2011 at 03:11:03PM -0800, David Miller wrote:
> >> From: "Matt Carlson" <mcarlson@broadcom•com>
> >> Date: Wed, 16 Feb 2011 15:06:13 -0800
> >>
> >> > On Wed, Feb 16, 2011 at 02:39:35PM -0800, Greg KH wrote:
> >> >> On Tue, Feb 15, 2011 at 02:51:10PM -0800, Matt Carlson wrote:
> >> >> > If management firmware is present and the device is down, the firmware
> >> >> > will assume control of the phy. If a phy access were allowed from the
> >> >> > host, it will collide with firmware phy accesses, resulting in
> >> >> > unpredictable behavior. This patch fixes the problem by disallowing phy
> >> >> > accesses during the problematic condition.
> >> >> >
> >> >> > Upstream commit ID f746a3136a61ae535c5d0b49a9418fa21edc61b5
> >> >>
> >> >> There is no such upstream git commit id in Linus's tree. What am I
> >> >> doing wrong here?
> >> >
> >> > The commit is in Dave Miller's net-next-2.6 tree.
> >> >
> >>
> >> If it wasn't appropriate for net-2.6, it absolutely it not appropriate
> >> for -stable.
> >
> > net-2.6 was the target tree for the patch. The stable_kernel_rules.txt
> > seemed to suggest that I could just CC stable@kernel•org with the
> > commit ID, and Greg would pull it in as the process dictates. If that
> > isn't correct, what is the preferred way to expedite the integration of
> > a patch?
>
> You are posting a commit ID for the net-next-2.6 tree, that's what triggered
> my response.
>
> Unless it also went into the net-2.6 tree (in which case you should
> give Greg the net-2.6 commit ID, which is also what the commit ID must
> be in Linus's tree right now), the change is not appropriate for
> -stable submission.
So the proper thing to do here is recall the patch, submit a new patch
to net-2.6 with a CC: stabel@kernel•org in the signed-off-by section.
Would I do the exact same thing if I were posting to net-next-2.6?
(i.e. the CC line tells you I want this patch to go to net-next-2.6,
net-2.6, then Linus's tree, then stable?) Or would you rather I posted
a completely different patchset against net-2.6?
next prev parent reply other threads:[~2011-02-17 0:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 22:51 [PATCH net-2.6/stable] tg3: Restrict phy ioctl access Matt Carlson
2011-02-16 22:39 ` [stable] " Greg KH
2011-02-16 23:06 ` Matt Carlson
2011-02-16 23:11 ` David Miller
2011-02-16 23:52 ` Matt Carlson
2011-02-17 0:00 ` Greg KH
2011-02-17 0:11 ` Matt Carlson
2011-02-17 0:10 ` David Miller
2011-02-17 0:39 ` Matt Carlson [this message]
2011-02-17 0:56 ` David Miller
2011-02-17 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217003947.GA11185@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=greg@kroah$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox