From: Andrew Morton <akpm@linux-foundation•org>
To: Stephen Hemminger <shemminger@linux-foundation•org>
Cc: netdev@vger•kernel.org, bugzilla-daemon@bugzilla•kernel.org,
bugme-daemon@bugzilla•kernel.org, gbillios@gmail•com
Subject: Re: [PATCH] skge: don't mark carrier down at start
Date: Wed, 23 Feb 2011 16:52:43 -0800 [thread overview]
Message-ID: <20110223165243.8a536913.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110223164449.2a5206b8@nehalam>
On Wed, 23 Feb 2011 16:44:49 -0800
Stephen Hemminger <shemminger@linux-foundation•org> wrote:
> The API for network devices has changed so that setting carrier
> off at probe is no longer required. This should fix the IPv6 addrconf
> issue.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
>
>
> --- a/drivers/net/skge.c 2011-02-23 16:40:36.351045685 -0800
> +++ b/drivers/net/skge.c 2011-02-23 16:40:48.315136410 -0800
> @@ -3856,9 +3856,6 @@ static struct net_device *skge_devinit(s
> memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port*8, ETH_ALEN);
> memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
>
> - /* device is off until link detection */
> - netif_carrier_off(dev);
> -
> return dev;
> }
Thanks, but please don't forget to acknowledge the bug reporter's
efforts.
Also, quoting the bugzilla URL in the changelog helps when people come
along to close off open bug reports.
From: Stephen Hemminger <shemminger@linux-foundation•org>
The API for network devices has changed so that setting carrier off at
probe is no longer required. This should fix the IPv6 addrconf issue.
Addresses https://bugzilla.kernel.org/show_bug.cgi?id=29612
Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
Reported-by: George Billios <gbillios@gmail•com>
Cc: David Miller <davem@davemloft•net>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---
drivers/net/skge.c | 3 ---
1 file changed, 3 deletions(-)
diff -puN drivers/net/skge.c~skge-dont-mark-carrier-down-at-start drivers/net/skge.c
--- a/drivers/net/skge.c~skge-dont-mark-carrier-down-at-start
+++ a/drivers/net/skge.c
@@ -3856,9 +3856,6 @@ static struct net_device *skge_devinit(s
memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port*8, ETH_ALEN);
memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
- /* device is off until link detection */
- netif_carrier_off(dev);
-
return dev;
}
_
next prev parent reply other threads:[~2011-02-24 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-29612-10286@https.bugzilla.kernel.org/>
2011-02-24 0:21 ` [Bugme-new] [Bug 29612] New: skge ipv6 doesn't work after boot Andrew Morton
2011-02-24 0:44 ` [PATCH] skge: don't mark carrier down at start Stephen Hemminger
2011-02-24 0:52 ` Andrew Morton [this message]
2011-02-25 6:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223165243.8a536913.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=bugme-daemon@bugzilla$(echo .)kernel.org \
--cc=bugzilla-daemon@bugzilla$(echo .)kernel.org \
--cc=gbillios@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox