From: Arnd Bergmann <arnd@arndb•de>
To: Greg KH <greg@kroah•com>
Cc: andy.green@linaro•org, Alan Cox <alan@lxorguk•ukuu.org.uk>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Nicolas Pitre <nicolas.pitre@linaro•org>,
Jaswinder Singh <jaswinder.singh@linaro•org>,
Linux USB list <linux-usb@vger•kernel.org>,
lkml <linux-kernel@vger•kernel.org>,
broonie@opensource•wolfsonmicro.com, roger.quadros@nokia•com,
grant.likely@secretlab•ca, netdev@vger•kernel.org,
David Brownell <dbrownell@users•sourceforge.net>
Subject: Re: [RFC] usbnet: use eth%d name for known ethernet devices
Date: Wed, 23 Mar 2011 20:35:17 +0100 [thread overview]
Message-ID: <201103232035.18232.arnd@arndb.de> (raw)
In-Reply-To: <20110323184650.GB21728@kroah.com>
On Wednesday 23 March 2011 19:46:50 Greg KH wrote:
> Looks good to me, but some questions:
>
> > drivers/usb/serial/usb_wwan.c | 2 +-
>
> You don't modify this file in the diff, what caused this to show up in
> the diffstat?
A stale change I had to do to get the kernel to build on my
machine. The original problem seems fixed now. I had removed
this hunk from the patch but forgot to remove it from the diffstat.
> > --- a/include/linux/usb/usbnet.h
> > +++ b/include/linux/usb/usbnet.h
> > @@ -97,6 +97,8 @@ struct driver_info {
> >
> > #define FLAG_LINK_INTR 0x0800 /* updates link (carrier) status */
> >
> > +#define FLAG_PTP 0x1000 /* maybe use "usb%d" names */
>
> "PTP"? What does that stand for?
point-to-point, I'll improve the comment to spell it out when I send the
fixed version.
Arnd
next prev parent reply other threads:[~2011-03-23 19:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D79F068.2080009@linaro.org>
[not found] ` <201103231712.06184.arnd@arndb.de>
[not found] ` <20110323162251.GA9367@kroah.com>
2011-03-23 16:56 ` [RFC] usbnet: use eth%d name for known ethernet devices Arnd Bergmann
2011-03-23 17:04 ` Andy Green
2011-03-23 17:11 ` Arnd Bergmann
[not found] ` <201103231811.54290.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-24 10:45 ` Andy Green
2011-03-23 17:13 ` Arnd Bergmann
2011-03-23 17:54 ` David Anders
2011-03-23 18:46 ` Greg KH
2011-03-23 19:35 ` Arnd Bergmann [this message]
[not found] ` <AANLkTim7hPfTv3gDYnh+jGxHBg0OvX=r1FKYoHnH7H_o@mail.gmail.com>
2011-03-23 19:57 ` Arnd Bergmann
2011-03-23 19:59 ` Randy Dunlap
2011-03-23 23:17 ` Michal Nazarewicz
2011-03-23 23:19 ` Randy Dunlap
2011-03-23 23:38 ` Steve Calfee
2011-03-24 0:01 ` Ben Hutchings
2011-03-24 13:13 ` Arnd Bergmann
2011-03-24 13:15 ` Arnd Bergmann
2011-03-24 13:44 ` Andy Green
[not found] ` <201103241415.45115.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-24 13:56 ` Alan Stern
2011-03-24 17:20 ` Alexey Orishko
2011-03-25 11:57 ` Arnd Bergmann
2011-03-25 16:26 ` Alexey Orishko
2011-03-25 16:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103232035.18232.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=andy.green@linaro$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=greg@kroah$(echo .)com \
--cc=jaswinder.singh@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.pitre@linaro$(echo .)org \
--cc=roger.quadros@nokia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox