From: Andy Green <andy@warmcat•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: Ben Hutchings <bhutchings@solarflare•com>,
Steve Calfee <stevecalfee@gmail•com>,
Michal Nazarewicz <mnazarewicz@gmail•com>,
Randy Dunlap <rdunlap@xenotime•net>,
broonie@opensource•wolfsonmicro.com,
lkml <linux-kernel@vger•kernel.org>,
Nicolas Pitre <nicolas.pitre@linaro•org>,
Greg KH <greg@kroah•com>,
David Brownell <dbrownell@users•sourceforge.net>,
Alan Cox <alan@lxorguk•ukuu.org.uk>,
grant.likely@secretlab•ca,
Linux USB list <linux-usb@vger•kernel.org>,
netdev@vger•kernel.org,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
roger.quadros@nokia•com,
Jaswinder Singh <jaswinder.singh@linaro•org>,
patches@linaro•org
Subject: Re: [RFC] usbnet: use eth%d name for known ethernet devices
Date: Thu, 24 Mar 2011 13:44:28 +0000 [thread overview]
Message-ID: <4D8B4ABC.9090203@linaro.org> (raw)
In-Reply-To: <201103241415.45115.arnd@arndb.de>
On 03/24/2011 01:15 PM, Somebody in the thread at some point said:
> The documentation for the USB ethernet devices suggests that
> only some devices are supposed to use usb0 as the network interface
> name instead of eth0. The logic used there, and documented in
> Kconfig for CDC is that eth0 will be used when the mac address
> is a globally assigned one, but usb0 is used for the locally
> managed range that is typically used on point-to-point links.
>
> Unfortunately, this has caused a lot of pain on the smsc95xx
> device that is used on the popular pandaboard without an
> EEPROM to store the MAC address, which causes the driver to
> call random_ether_address().
>
> Obviously, there should be a proper MAC addressed assigned to
> the device, and discussions are ongoing about how to solve
> this, but this patch at least makes sure that the default
> interface naming gets a little saner and matches what the
> user can expect based on the documentation, including for
> new devices.
>
> The approach taken here is to flag whether a device might be a
> point-to-point link with the new FLAG_PTP setting in the usbnet
> driver_info. A driver can set both FLAG_PTP and FLAG_ETHER if
> it is not sure (e.g. cdc_ether), or just one of the two.
> The usbnet framework only looks at the MAC address for device
> naming if both flags are set, otherwise it trusts the flag.
>
> Signed-off-by: Arnd Bergmann<arnd.bergmann@linaro•org>
> Cc: Andy Green<andy.green@linaro•org>
> Cc: patches@linaro•org
For Panda case at least,
Tested-by: Andy Green <andy.green@linaro•org>
-Andy
next prev parent reply other threads:[~2011-03-24 13:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D79F068.2080009@linaro.org>
[not found] ` <201103231712.06184.arnd@arndb.de>
[not found] ` <20110323162251.GA9367@kroah.com>
2011-03-23 16:56 ` [RFC] usbnet: use eth%d name for known ethernet devices Arnd Bergmann
2011-03-23 17:04 ` Andy Green
2011-03-23 17:11 ` Arnd Bergmann
[not found] ` <201103231811.54290.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-24 10:45 ` Andy Green
2011-03-23 17:13 ` Arnd Bergmann
2011-03-23 17:54 ` David Anders
2011-03-23 18:46 ` Greg KH
2011-03-23 19:35 ` Arnd Bergmann
[not found] ` <AANLkTim7hPfTv3gDYnh+jGxHBg0OvX=r1FKYoHnH7H_o@mail.gmail.com>
2011-03-23 19:57 ` Arnd Bergmann
2011-03-23 19:59 ` Randy Dunlap
2011-03-23 23:17 ` Michal Nazarewicz
2011-03-23 23:19 ` Randy Dunlap
2011-03-23 23:38 ` Steve Calfee
2011-03-24 0:01 ` Ben Hutchings
2011-03-24 13:13 ` Arnd Bergmann
2011-03-24 13:15 ` Arnd Bergmann
2011-03-24 13:44 ` Andy Green [this message]
[not found] ` <201103241415.45115.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-24 13:56 ` Alan Stern
2011-03-24 17:20 ` Alexey Orishko
2011-03-25 11:57 ` Arnd Bergmann
2011-03-25 16:26 ` Alexey Orishko
2011-03-25 16:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8B4ABC.9090203@linaro.org \
--to=andy@warmcat$(echo .)com \
--cc=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=andy.green@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhutchings@solarflare$(echo .)com \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=greg@kroah$(echo .)com \
--cc=jaswinder.singh@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=mnazarewicz@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.pitre@linaro$(echo .)org \
--cc=patches@linaro$(echo .)org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=roger.quadros@nokia$(echo .)com \
--cc=stevecalfee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox