From: Stephen Hemminger <shemminger@vyatta•com>
To: "David S. Miller" <davem@davmeloft•net>
Cc: netdev@vger•kernel.org
Subject: [PATCH 3/5] bridge: notifier called with the wrong device
Date: Fri, 22 Jul 2011 10:47:08 -0700 [thread overview]
Message-ID: <20110722174758.036523438@vyatta.com> (raw)
In-Reply-To: 20110722174705.144993799@vyatta.com
[-- Attachment #1: br-notify-wrong-dev.patch --]
[-- Type: text/plain, Size: 819 bytes --]
If a new device is added to a bridge, the ethernet address of the
bridge network device may change. When the address changes, the
appropriate callback is called, but with the wrong device argument.
The address of the bridge device (ie br0) changes not the address
of the device being passed to add_if (ie eth0).
Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
---
Patch against net-next. Should go to stable.
--- a/net/bridge/br_if.c 2011-07-21 20:13:13.539989381 -0700
+++ b/net/bridge/br_if.c 2011-07-21 20:23:12.091989045 -0700
@@ -388,7 +388,7 @@ int br_add_if(struct net_bridge *br, str
br_ifinfo_notify(RTM_NEWLINK, p);
if (changed_addr)
- call_netdevice_notifiers(NETDEV_CHANGEADDR, dev);
+ call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);
dev_set_mtu(br->dev, br_min_mtu(br));
next prev parent reply other threads:[~2011-07-22 17:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 17:47 [PATCH 0/5] bridge patchs Stephen Hemminger
2011-07-22 17:47 ` [PATCH 1/5] bridge: send proper message_age in config BPDU Stephen Hemminger
2011-07-22 17:47 ` [PATCH 2/5] bridge: ignore bogus STP config packets Stephen Hemminger
2011-07-22 17:47 ` Stephen Hemminger [this message]
2011-07-22 17:47 ` [PATCH 4/5] [PATCH] bridge: add notification over netlink when STP changes state Stephen Hemminger
2011-07-22 17:47 ` [PATCH 5/5] bridge: minor cleanups Stephen Hemminger
2011-07-23 0:15 ` [PATCH 0/5] bridge patchs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722174758.036523438@vyatta.com \
--to=shemminger@vyatta$(echo .)com \
--cc=davem@davmeloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox