From: "Michael S. Tsirkin" <mst@redhat•com>
To: Neil Horman <nhorman@tuxdriver•com>, mashirle@us•ibm.com
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH 0/2] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods (v3)
Date: Fri, 29 Jul 2011 09:16:42 +0300 [thread overview]
Message-ID: <20110729061642.GA9884@redhat.com> (raw)
In-Reply-To: <1311696338-4739-1-git-send-email-nhorman@tuxdriver.com>
On Tue, Jul 26, 2011 at 12:05:36PM -0400, Neil Horman wrote:
> Ok, after considering all your comments, Dave suggested this as an alternate
> approach:
>
> 1) We create a new priv_flag, IFF_SKB_TX_SHARED, to identify drivers capable of
> handling shared skbs. Default is to not set this flag
>
> 2) Modify ether_setup to enable this flag, under the assumption that any driver
> calling this function is initalizing a real ethernet device and as such can
> handle shared skbs since they don't tend to store state in the skb struct.
> Pktgen can then query this flag when a user script attempts to issue the
> clone_skb command and decide if it is to be alowed or not.
>
> 3) Audit the network drivers calling ether_setup to identify any code doing so
> that can't actualy handle shared skbs and manually disable the new flag. There
> are about 10 drivers in this category.
>
> Change notes:
> v3) Fixed Erics note in which I tested the length of the passed in string rather
> than its converted value for beign > 0
>
> Thoughts/reviews aprpeciated.
> Neil
It might be a good idea to disable vhost-net zerocopy for
such devices as well: these skbs are shared with userspace.
Shirley, what do you think?
--
MST
next prev parent reply other threads:[~2011-07-29 6:16 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 19:52 [PATCH] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods Neil Horman
2011-07-19 20:02 ` Eric Dumazet
2011-07-19 20:17 ` Joe Perches
2011-07-19 20:29 ` Jiri Pirko
2011-07-19 20:41 ` Eric Dumazet
2011-07-19 21:01 ` Ben Greear
2011-07-20 0:19 ` Neil Horman
2011-07-20 0:25 ` Rick Jones
2011-07-20 15:23 ` Loke, Chetan
2011-07-20 0:43 ` Eric Dumazet
2011-07-20 0:52 ` Ben Greear
2011-07-20 2:07 ` Neil Horman
2011-07-20 4:19 ` Ben Greear
2011-07-20 4:24 ` Eric Dumazet
2011-07-20 15:17 ` Loke, Chetan
2011-07-20 15:18 ` Neil Horman
2011-07-20 15:30 ` Eric Dumazet
2011-07-20 15:39 ` Neil Horman
2011-07-20 15:44 ` Eric Dumazet
2011-07-20 16:19 ` Neil Horman
2011-07-20 15:35 ` Michał Mirosław
2011-07-20 15:40 ` Neil Horman
2011-07-20 16:08 ` Michał Mirosław
2011-07-20 16:18 ` Neil Horman
2011-07-20 16:37 ` Ben Greear
2011-07-20 16:33 ` Ben Greear
2011-07-20 16:36 ` Neil Horman
2011-07-21 22:01 ` David Miller
2011-07-21 22:14 ` Ben Greear
2011-07-21 22:19 ` David Miller
2011-07-21 22:26 ` Ben Greear
2011-07-21 23:50 ` Neil Horman
2011-07-22 0:08 ` David Miller
2011-07-22 1:37 ` Neil Horman
2011-07-20 1:59 ` Neil Horman
2011-07-25 19:45 ` [PATCH 0/2] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods (v2) Neil Horman
2011-07-25 19:45 ` [PATCH 1/2] net: add IFF_SKB_TX_SHARED flag to priv_flags Neil Horman
2011-07-25 20:11 ` Eric Dumazet
2011-07-26 14:54 ` Neil Horman
2011-07-25 19:45 ` [PATCH 2/2] net: Audit drivers to identify those needing IFF_TX_SKB_SHARING cleared Neil Horman
2011-07-26 18:34 ` Krzysztof Halasa
2011-07-26 16:05 ` [PATCH 0/2] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods (v3) Neil Horman
2011-07-26 16:05 ` [PATCH 1/2] net: add IFF_SKB_TX_SHARED flag to priv_flags Neil Horman
2011-07-28 5:42 ` David Miller
2011-07-28 8:15 ` Robert Olsson
2011-07-28 10:50 ` Neil Horman
2011-07-26 16:05 ` [PATCH 2/2] net: Audit drivers to identify those needing IFF_TX_SKB_SHARING cleared Neil Horman
2011-07-28 5:42 ` David Miller
2011-07-29 6:16 ` Michael S. Tsirkin [this message]
2011-07-29 11:19 ` [PATCH 0/2] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods (v3) Neil Horman
2011-08-17 15:07 ` Ben Hutchings
2011-08-22 0:27 ` Neil Horman
2011-08-22 16:17 ` Ben Hutchings
2011-08-22 17:33 ` Ben Hutchings
2011-08-22 18:14 ` Neil Horman
2011-08-23 14:01 ` Ben Hutchings
2011-08-23 15:13 ` Neil Horman
2011-08-23 15:53 ` Ben Hutchings
2011-08-23 16:21 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729061642.GA9884@redhat.com \
--to=mst@redhat$(echo .)com \
--cc=mashirle@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox