From: Ben Greear <greearb@candelatech•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Jiri Pirko <jpirko@redhat•com>,
Neil Horman <nhorman@tuxdriver•com>,
netdev@vger•kernel.org, Alexey Dobriyan <adobriyan@gmail•com>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods
Date: Tue, 19 Jul 2011 14:01:23 -0700 [thread overview]
Message-ID: <4E25F0A3.8020509@candelatech.com> (raw)
In-Reply-To: <1311108107.3113.22.camel@edumazet-laptop>
On 07/19/2011 01:41 PM, Eric Dumazet wrote:
> Le mardi 19 juillet 2011 à 22:29 +0200, Jiri Pirko a écrit :
>
>> You are right, but it may not cause panic, right? In case this patch
>> would cause significant performance regression, how about to just forbid
>> pktgen to run on soft-netdevs ?
>>
>
> Please do
No, please do not. Pktgen *can* work on soft-devs if you do not
use multi-skb, and it can be useful for testing highs speed vlan
traffic and various other things.
If you must, forbid multi-skb on soft devices, but don't just
break pktgen for all soft-devices.
Thanks,
Ben
>
> Note : a sysadmin has other ways to make a machine panic or reboot or
> halt...
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-07-19 21:01 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 19:52 [PATCH] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods Neil Horman
2011-07-19 20:02 ` Eric Dumazet
2011-07-19 20:17 ` Joe Perches
2011-07-19 20:29 ` Jiri Pirko
2011-07-19 20:41 ` Eric Dumazet
2011-07-19 21:01 ` Ben Greear [this message]
2011-07-20 0:19 ` Neil Horman
2011-07-20 0:25 ` Rick Jones
2011-07-20 15:23 ` Loke, Chetan
2011-07-20 0:43 ` Eric Dumazet
2011-07-20 0:52 ` Ben Greear
2011-07-20 2:07 ` Neil Horman
2011-07-20 4:19 ` Ben Greear
2011-07-20 4:24 ` Eric Dumazet
2011-07-20 15:17 ` Loke, Chetan
2011-07-20 15:18 ` Neil Horman
2011-07-20 15:30 ` Eric Dumazet
2011-07-20 15:39 ` Neil Horman
2011-07-20 15:44 ` Eric Dumazet
2011-07-20 16:19 ` Neil Horman
2011-07-20 15:35 ` Michał Mirosław
2011-07-20 15:40 ` Neil Horman
2011-07-20 16:08 ` Michał Mirosław
2011-07-20 16:18 ` Neil Horman
2011-07-20 16:37 ` Ben Greear
2011-07-20 16:33 ` Ben Greear
2011-07-20 16:36 ` Neil Horman
2011-07-21 22:01 ` David Miller
2011-07-21 22:14 ` Ben Greear
2011-07-21 22:19 ` David Miller
2011-07-21 22:26 ` Ben Greear
2011-07-21 23:50 ` Neil Horman
2011-07-22 0:08 ` David Miller
2011-07-22 1:37 ` Neil Horman
2011-07-20 1:59 ` Neil Horman
2011-07-25 19:45 ` [PATCH 0/2] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods (v2) Neil Horman
2011-07-25 19:45 ` [PATCH 1/2] net: add IFF_SKB_TX_SHARED flag to priv_flags Neil Horman
2011-07-25 20:11 ` Eric Dumazet
2011-07-26 14:54 ` Neil Horman
2011-07-25 19:45 ` [PATCH 2/2] net: Audit drivers to identify those needing IFF_TX_SKB_SHARING cleared Neil Horman
2011-07-26 18:34 ` Krzysztof Halasa
2011-07-26 16:05 ` [PATCH 0/2] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods (v3) Neil Horman
2011-07-26 16:05 ` [PATCH 1/2] net: add IFF_SKB_TX_SHARED flag to priv_flags Neil Horman
2011-07-28 5:42 ` David Miller
2011-07-28 8:15 ` Robert Olsson
2011-07-28 10:50 ` Neil Horman
2011-07-26 16:05 ` [PATCH 2/2] net: Audit drivers to identify those needing IFF_TX_SKB_SHARING cleared Neil Horman
2011-07-28 5:42 ` David Miller
2011-07-29 6:16 ` [PATCH 0/2] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods (v3) Michael S. Tsirkin
2011-07-29 11:19 ` Neil Horman
2011-08-17 15:07 ` Ben Hutchings
2011-08-22 0:27 ` Neil Horman
2011-08-22 16:17 ` Ben Hutchings
2011-08-22 17:33 ` Ben Hutchings
2011-08-22 18:14 ` Neil Horman
2011-08-23 14:01 ` Ben Hutchings
2011-08-23 15:13 ` Neil Horman
2011-08-23 15:53 ` Ben Hutchings
2011-08-23 16:21 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E25F0A3.8020509@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jpirko@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox