From: Mark Brown <broonie@opensource•wolfsonmicro.com>
To: Mike Frysinger <vapier@gentoo•org>
Cc: Linus Walleij <linus.walleij@stericsson•com>,
netdev@vger•kernel.org,
Steve Glendinning <steve.glendinning@smsc•com>,
Mathieu Poirer <mathieu.poirier@linaro•org>,
Robert Marklund <robert.marklund@stericsson•com>,
Paul Mundt <lethal@linux-sh•org>,
linux-sh@vger•kernel.org, Sascha Hauer <s.hauer@pengutronix•de>,
Tony Lindgren <tony@atomide•com>,
linux-omap@vger•kernel.org,
uclinux-dist-devel@blackfin•uclinux.org,
Linus Walleij <linus.walleij@linaro•org>
Subject: Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support
Date: Thu, 27 Oct 2011 16:46:38 +0100 [thread overview]
Message-ID: <20111027154638.GA16946@sirena.org.uk> (raw)
In-Reply-To: <CAJaTeTrzFwxsn22U-NHQ8iCiaUM+mj8PyicavR-DN0HgE08ZEQ@mail.gmail.com>
On Thu, Oct 27, 2011 at 03:21:47PM +0200, Mike Frysinger wrote:
> my gut reaction: smsc911x is working just fine without regulator
> support for many people, so why do we suddenly need to make it a
> requirement ? this is a fairly small amount of code, so adding a
> smsc911x Kconfig symbol to control the regulator support seems like
> overkill. only other option would be to change the patch to not make
> missing regulators non-fatal. so i'd probably lean towards the latter
> (and it sounds like you changed this with earlier versions).
The regulator API contains a series of generic facilities for stubbing
itself out when not in use - there's no need for individual drivers to
worry about this stuff, they should just rely on the framework. The
main one at the minute is REGULATOR_DUMMY which does what you suggest
and makes regulator_get() never fail.
next prev parent reply other threads:[~2011-10-27 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 12:48 [PATCH 2/2 v3] net/smsc911x: Add regulator support Linus Walleij
2011-10-27 13:21 ` Mike Frysinger
2011-10-27 15:46 ` Mark Brown [this message]
2011-10-27 20:59 ` Mike Frysinger
2011-10-27 21:42 ` Mark Brown
2011-10-27 22:43 ` Mike Frysinger
2011-10-28 20:33 ` Sascha Hauer
2011-10-28 23:33 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027154638.GA16946@sirena.org.uk \
--to=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=lethal@linux-sh$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linus.walleij@stericsson$(echo .)com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=mathieu.poirier@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robert.marklund@stericsson$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=steve.glendinning@smsc$(echo .)com \
--cc=tony@atomide$(echo .)com \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
--cc=vapier@gentoo$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox