From: Sascha Hauer <s.hauer@pengutronix•de>
To: Linus Walleij <linus.walleij@stericsson•com>
Cc: netdev@vger•kernel.org,
Steve Glendinning <steve.glendinning@smsc•com>,
Mathieu Poirer <mathieu.poirier@linaro•org>,
Robert Marklund <robert.marklund@stericsson•com>,
Paul Mundt <lethal@linux-sh•org>,
linux-sh@vger•kernel.org, Tony Lindgren <tony@atomide•com>,
linux-omap@vger•kernel.org, Mike Frysinger <vapier@gentoo•org>,
uclinux-dist-devel@blackfin•uclinux.org,
Linus Walleij <linus.walleij@linaro•org>
Subject: Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support
Date: Fri, 28 Oct 2011 22:33:53 +0200 [thread overview]
Message-ID: <20111028203353.GE23421@pengutronix.de> (raw)
In-Reply-To: <1319719691-15799-1-git-send-email-linus.walleij@stericsson.com>
Hi Linus,
On Thu, Oct 27, 2011 at 02:48:11PM +0200, Linus Walleij wrote:
> From: Robert Marklund <robert.marklund@stericsson•com>
>
> Add some basic regulator support for the power pins, as needed
> by the ST-Ericsson Snowball platform that powers up the SMSC911
> chip using an external regulator.
>
> Platforms that use regulators and the smsc911x and have no defined
> regulator for the smsc911x and claim complete regulator
> constraints with no dummy regulators will need to provide it, for
> example using a fixed voltage regulator. It appears that this may
> affect (apart from Ux500 Snowball) possibly these archs/machines
> that from some grep:s appear to define both CONFIG_SMSC911X and
> CONFIG_REGULATOR:
>
> - ARM Freescale mx3 and OMAP 2 plus, Raumfeld machines
> - Blackfin
> - Super-H
>
...
>
> +
> +/*
> + * Request or free resources, currently just regulators.
> + *
> + * The SMSC911x has two power pins: vddvario and vdd33a, in designs where
> + * these are not always-on we need to request regulators to be turned on
> + * before we can try to access the device registers.
> + */
> +static int smsc911x_request_free_resources(struct platform_device *pdev,
> + bool request)
I had to look twice at this function name. First I thought "request the
free resources?", which other resources would you request if not the
free ones? I think it would be nicer to have two functions instead.
Just my 2 cents.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-10-28 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 12:48 [PATCH 2/2 v3] net/smsc911x: Add regulator support Linus Walleij
2011-10-27 13:21 ` Mike Frysinger
2011-10-27 15:46 ` Mark Brown
2011-10-27 20:59 ` Mike Frysinger
2011-10-27 21:42 ` Mark Brown
2011-10-27 22:43 ` Mike Frysinger
2011-10-28 20:33 ` Sascha Hauer [this message]
2011-10-28 23:33 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028203353.GE23421@pengutronix.de \
--to=s.hauer@pengutronix$(echo .)de \
--cc=lethal@linux-sh$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linus.walleij@stericsson$(echo .)com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=mathieu.poirier@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robert.marklund@stericsson$(echo .)com \
--cc=steve.glendinning@smsc$(echo .)com \
--cc=tony@atomide$(echo .)com \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
--cc=vapier@gentoo$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox