From: "Matt Carlson" <mcarlson@broadcom•com>
To: "David Miller" <davem@davemloft•net>
Cc: "Matthew Carlson" <mcarlson@broadcom•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Michael Chan" <mchan@broadcom•com>
Subject: Re: [PATCH] Add ethtool to mii advertisment conversion helpers
Date: Wed, 16 Nov 2011 14:56:32 -0800 [thread overview]
Message-ID: <20111116225632.GA3556@mcarlson.broadcom.com> (raw)
In-Reply-To: <20111116.173618.213297028503733251.davem@davemloft.net>
On Wed, Nov 16, 2011 at 02:36:18PM -0800, David Miller wrote:
> From: "Matt Carlson" <mcarlson@broadcom•com>
> Date: Tue, 15 Nov 2011 14:00:53 -0800
>
> > Translating between ethtool advertisement settings and MII
> > advertisements are common operations for ethernet drivers. This patch
> > adds a set of helper functions that implements the conversion. The
> > patch then modifies a couple of the drivers to use the new functions.
> >
> > Signed-off-by: Matt Carlson <mcarlson@broadcom•com>
> > Signed-off-by: Michael Chan <mchan@broadcom•com>
>
> Doesn't build:
>
> In file included from drivers/net/ethernet/3com/3c59x.c:82:0:
> include/linux/mii.h: In function ?ethtool_adv_to_mii_100bt?:
> include/linux/mii.h:254:15: error: ?ADVERTISED_10baseT_Half? undeclared (first use in this function)
> include/linux/mii.h:254:15: note: each undeclared identifier is reported only once for each function it appears in
> include/linux/mii.h:256:15: error: ?ADVERTISED_10baseT_Full? undeclared (first use in this function)
> include/linux/mii.h:258:15: error: ?ADVERTISED_100baseT_Half? undeclared (first use in this function)
> include/linux/mii.h:260:15: error: ?ADVERTISED_100baseT_Full? undeclared (first use in this function)
> include/linux/mii.h:262:15: error: ?ADVERTISED_Pause? undeclared (first use in this function)
> include/linux/mii.h:264:15: error: ?ADVERTISED_Asym_Pause? undeclared (first use in this function)
I forgot to add '#include <linux\ethtool.h>' to mii.h. I guess for the
drivers I enabled, ethtool.h was already included. New patch on its
way.
next prev parent reply other threads:[~2011-11-16 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 22:00 [PATCH] Add ethtool to mii advertisment conversion helpers Matt Carlson
2011-11-16 22:36 ` David Miller
2011-11-16 22:56 ` Matt Carlson [this message]
2011-11-17 0:34 ` Ben Hutchings
2011-11-17 1:16 ` Matt Carlson
2011-11-17 1:21 ` Michael Chan
2011-11-17 1:38 ` David Miller
2011-11-17 2:29 ` Ben Hutchings
2011-11-17 1:29 ` Ben Hutchings
2011-11-17 2:06 ` Matt Carlson
2011-11-17 2:45 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116225632.GA3556@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox