From: Flavio Leitner <fbl@redhat•com>
To: mjr@cs•wisc.edu
Cc: davem@davemloft•net, sboyd@codeaurora•org, ben@simtec•co.uk,
bhutchings@solarflare•com, netdev@vger•kernel.org
Subject: Re: [PATCH] ks8851: Fix missing mutex_lock/unlock
Date: Thu, 12 Apr 2012 21:22:13 -0300 [thread overview]
Message-ID: <20120412212213.746ec2e2@asterix.rh> (raw)
In-Reply-To: <1334272530-11119-1-git-send-email-mjr@cs.wisc.edu>
On Thu, 12 Apr 2012 18:15:30 -0500
mjr@cs•wisc.edu wrote:
> From: Matt Renzelmann <mjr@cs•wisc.edu>
>
> All calls to ks8851_rdreg* and ks8851_wrreg* should be protected with
> the driver's lock mutex. A spurious interrupt may otherwise cause a
> crash. Thanks to Stephen Boyd, Flavio Leitner, and Ben Hutchings for
> feedback.
>
> Signed-off-by: Matt Renzelmann <mjr@cs•wisc.edu>
> ---
>
> This modified version incorporates Ben Hutchings' bugfix by removing
> the incorrect call to CIDER_REV_GET.
>
> drivers/net/ethernet/micrel/ks8851.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c
> index c722aa6..e5dc075 100644
> --- a/drivers/net/ethernet/micrel/ks8851.c
> +++ b/drivers/net/ethernet/micrel/ks8851.c
> @@ -1418,6 +1418,7 @@ static int __devinit ks8851_probe(struct spi_device *spi)
> struct net_device *ndev;
> struct ks8851_net *ks;
> int ret;
> + unsigned cider;
Basically what I have proposed, but I used 'unsigned int cider'.
Anyway, the driver uses just 'unsigned' everywhere.
Signed-off-by: Flavio Leitner <fbl@redhat•com>
next prev parent reply other threads:[~2012-04-13 0:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 23:15 [PATCH] ks8851: Fix missing mutex_lock/unlock mjr
2012-04-13 0:22 ` Flavio Leitner [this message]
2012-04-13 17:46 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2012-04-13 17:59 mjr
2012-04-13 18:05 ` David Miller
2012-04-12 21:28 mjr
2012-04-12 22:03 ` Ben Hutchings
2012-04-12 20:06 mjr
2012-04-12 20:34 ` Stephen Boyd
2012-04-12 20:56 ` Matt Renzelmann
2012-04-12 20:59 ` Flavio Leitner
2012-04-12 21:19 ` Flavio Leitner
2012-04-12 20:40 ` Flavio Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412212213.746ec2e2@asterix.rh \
--to=fbl@redhat$(echo .)com \
--cc=ben@simtec$(echo .)co.uk \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mjr@cs$(echo .)wisc.edu \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sboyd@codeaurora$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox