public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Andrew Lunn <andrew@lunn•ch>
To: Josh Boyer <jwboyer@redhat•com>
Cc: Ben Hutchings <ben@decadent•org.uk>,
	Lennert Buytenhek <buytenh@wantstofly•org>,
	Andrew Lunn <andrew@lunn•ch>, Olof Johansson <olof@lixom•net>,
	netdev@vger•kernel.org
Subject: Re: [PATCH] netdev: mv643xx_eth: Prevent build on PPC32
Date: Wed, 6 Jun 2012 07:29:10 +0200	[thread overview]
Message-ID: <20120606052910.GA674@lunn.ch> (raw)
In-Reply-To: <20120606023842.GD7683@zod.bos.redhat.com>

> The proper fix, from my minimal looking, was one of:
> 
> 1) revert the change for ARM that introduced th clk stuff
> 2) do a similar change as the original commit but with a bunch of
> #ifdef-ery
> 3) implement the clkdev API stuff for 32-bit ppc
> 
> Honestly, I'd go for either 1 or 2.  The commit that introduced it was
> broken to begin with, but that isn't my call.

I broke it. Sorry.

At the time, there was a push to remove all the #ifdefs. The following
patchset was doing this:

https://lkml.org/lkml/2012/4/21/94

it would provide dummy implementations for those systems without clk
support. However, it seems that patch set never made it in, and i did
not declare my dependency on it.

I'm happy to add #ifdef. However, i would first like to understand
what was 'broken to begin with'.

     Thanks
	Andrew

next prev parent reply	other threads:[~2012-06-06  5:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05 19:28 [PATCH] netdev: mv643xx_eth: Prevent build on PPC32 Josh Boyer
2012-06-05 23:30 ` Ben Hutchings
2012-06-06  2:38   ` Josh Boyer
2012-06-06  5:29     ` Andrew Lunn [this message]
2012-06-06 11:21       ` Josh Boyer
2012-06-07 23:51     ` Mark Brown
2012-06-07 23:55       ` Josh Boyer
2012-06-08  0:34         ` Mark Brown
2012-06-08  1:04           ` Josh Boyer
2012-06-09  4:01             ` Mark Brown
2012-06-06  0:49 ` Lennert Buytenhek
2012-06-06  2:40   ` Josh Boyer
2012-06-06  3:02     ` Lennert Buytenhek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120606052910.GA674@lunn.ch \
    --to=andrew@lunn$(echo .)ch \
    --cc=ben@decadent$(echo .)org.uk \
    --cc=buytenh@wantstofly$(echo .)org \
    --cc=jwboyer@redhat$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=olof@lixom$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox