From: Andrew Lunn <andrew@lunn•ch>
To: Arnd Bergmann <arnd@arndb•de>
Cc: Ian Molton <ian.molton@codethink•co.uk>,
linux-arm-kernel@lists•infradead.org, andrew@lunn•ch,
thomas.petazzoni@free-electrons•com, ben.dooks@codethink•co.uk,
netdev@vger•kernel.org
Subject: Re: [PATCH v2 3/6] mv643xx.c: Add basic device tree support.
Date: Tue, 31 Jul 2012 21:24:58 +0200 [thread overview]
Message-ID: <20120731192458.GE28852@lunn.ch> (raw)
In-Reply-To: <201207311823.54857.arnd@arndb.de>
On Tue, Jul 31, 2012 at 06:23:54PM +0000, Arnd Bergmann wrote:
> On Tuesday 31 July 2012, Ian Molton wrote:
> > @@ -33,6 +34,10 @@ struct of_dev_auxdata kirkwood_auxdata_lookup[] __initdata = {
> > OF_DEV_AUXDATA("marvell,orion-wdt", 0xf1020300, "orion_wdt", NULL),
> > OF_DEV_AUXDATA("marvell,orion-sata", 0xf1080000, "sata_mv.0", NULL),
> > OF_DEV_AUXDATA("marvell,orion-nand", 0xf4000000, "orion_nand", NULL),
> > + OF_DEV_AUXDATA("marvell,mv643xx", 0xf1072000, MV643XX_ETH_NAME ".0",
> > + NULL),
> > + OF_DEV_AUXDATA("marvell,mv643xx", 0xf1076000, MV643XX_ETH_NAME ".1",
> > + NULL),
> > {},
> > };
>
> Please don't do string concatenation like this, it just makes it harder to grep for the
> strings.
Hi Arnd
This pattern is used in other places, e.g. when creating the
clocks. The macro MV643XX_ETH_NAME is also used when creating the
platform data, and in the driver itself.
Are you suggested we replace this with "mv643xx_eth.0"? Or is adding
the macro
#define MV643XX_ETH_NAME0 "mv643xx_eth.0"
in include/linux/mv643xx_eth.h O.K, since grep will find it, and
induce the grep'er to perform a second grep on the macro?
Andrew
next prev parent reply other threads:[~2012-07-31 19:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 15:45 [PATCH v2 0/6] mv643xx Ethernet DT support and CSB1724 board support Ian Molton
2012-07-31 15:45 ` [PATCH v2 1/6] Initial csb1724 board support (FDT) Ian Molton
2012-07-31 16:43 ` Andrew Lunn
2012-07-31 15:45 ` [PATCH v2 2/6] mv643xx.c: Remove magic numbers Ian Molton
2012-07-31 15:45 ` [PATCH v2 3/6] mv643xx.c: Add basic device tree support Ian Molton
2012-07-31 16:46 ` Andrew Lunn
2012-08-01 8:50 ` Ian Molton
2012-07-31 18:23 ` Arnd Bergmann
2012-07-31 19:24 ` Andrew Lunn [this message]
2012-07-31 20:18 ` Arnd Bergmann
2012-07-31 15:45 ` [PATCH v2 4/6] kirkwood: Add a clock setup helper for mv643xx ethernet Ian Molton
2012-07-31 15:45 ` [PATCH v2 5/6] csb1724: Enable device tree based mv643xx ethernet support Ian Molton
2012-07-31 15:45 ` [PATCH v2 6/6] DT: Convert all kirkwood boards with mv643xx that use DT Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731192458.GE28852@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=ben.dooks@codethink$(echo .)co.uk \
--cc=ian.molton@codethink$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox