From: Tejun Heo <tj@kernel•org>
To: Sasha Levin <levinsasha928@gmail•com>
Cc: NeilBrown <neilb@suse•de>,
torvalds@linux-foundation•org, akpm@linux-foundation•org,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
paul.gortmaker@windriver•com, davem@davemloft•net,
rostedt@goodmis•org, mingo@elte•hu, ebiederm@xmission•com,
aarcange@redhat•com, ericvh@gmail•com, netdev@vger•kernel.org,
josh@joshtriplett•org, eric.dumazet@gmail•com,
mathieu.desnoyers@efficios•com, axboe@kernel•dk, agk@redhat•com,
dm-devel@redhat•com, ccaulfie@redhat•com, teigland@redhat•com,
Trond.Myklebust@netapp•com, bfields@fieldses•org,
fweisbec@gmail•com, jesse@nicira•com,
venkat.x.venkatsubra@oracle•com, ejt@redhat•com,
snitzer@redhat•com, edumazet@google•com,
linux-nfs@vger•kernel.org, dev@openvswitch•org,
rds-devel@oss•oracle.com, lw@cn•fujitsu.com
Subject: Re: [PATCH 01/16] hashtable: introduce a small and naive hashtable
Date: Tue, 14 Aug 2012 17:28:34 -0700 [thread overview]
Message-ID: <20120815002834.GI25632@google.com> (raw)
In-Reply-To: <502AEC51.2010305@gmail.com>
Hello,
(Sasha, would it be possible to change your MUA so that it breaks long
lines. It's pretty difficult to reply to.)
On Wed, Aug 15, 2012 at 02:24:49AM +0200, Sasha Levin wrote:
> The hashtable uses hlist. hlist provides us with an entire family of
> init functions which I'm supposed to use to initialize hlist heads.
>
> So while a memset(0) will work perfectly here, I consider that
> cheating - it results in an uglier code that assumes to know about
> hlist internals, and will probably break as soon as someone tries to
> do something to hlist.
I think we should stick with INIT_HLIST_HEAD(). It's not a hot path
and we might add, say, debug fields or initialization magics added
later. If this really matters, the right thing to do would be adding
something like INIT_HLIST_HEAD_ARRAY().
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
next prev parent reply other threads:[~2012-08-15 0:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 16:24 [PATCH 00/16] generic hashtable implementation Sasha Levin
2012-08-14 16:24 ` [PATCH 02/16] user_ns: use new " Sasha Levin
2012-08-14 23:52 ` Eric W. Biederman
[not found] ` <87txw5hw0s.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-08-15 0:47 ` Sasha Levin
[not found] ` <502AF184.4010907-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-15 1:08 ` Eric W. Biederman
2012-08-15 1:35 ` Sasha Levin
[not found] ` <502AFCD5.6070104-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-15 3:13 ` Eric W. Biederman
2012-08-15 3:31 ` Mathieu Desnoyers
2012-08-15 13:40 ` Sasha Levin
[not found] ` <87obmchmpu.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-08-15 8:46 ` David Laight
[not found] ` <AE90C24D6B3A694183C094C60CF0A2F6026B6FB5-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2012-08-16 14:28 ` Mathieu Desnoyers
2012-08-14 16:24 ` [PATCH 03/16] mm,ksm: " Sasha Levin
[not found] ` <1344961490-4068-1-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-14 16:24 ` [PATCH 01/16] hashtable: introduce a small and naive hashtable Sasha Levin
[not found] ` <1344961490-4068-2-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-14 23:25 ` NeilBrown
[not found] ` <20120815092523.00a909ef-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2012-08-15 0:24 ` Sasha Levin
2012-08-15 0:28 ` Tejun Heo [this message]
2012-08-14 16:24 ` [PATCH 04/16] workqueue: use new hashtable implementation Sasha Levin
2012-08-14 16:24 ` [PATCH 05/16] mm/huge_memory: " Sasha Levin
2012-08-14 16:24 ` [PATCH 06/16] tracepoint: " Sasha Levin
2012-08-14 16:24 ` [PATCH 08/16] block, elevator: " Sasha Levin
2012-08-14 16:24 ` [PATCH 09/16] SUNRPC/cache: " Sasha Levin
2012-08-14 16:24 ` [PATCH 10/16] dlm: " Sasha Levin
2012-08-14 16:24 ` [PATCH 11/16] net, l2tp: " Sasha Levin
2012-08-14 16:24 ` [PATCH 12/16] dm: " Sasha Levin
2012-08-14 16:24 ` [PATCH 13/16] lockd: " Sasha Levin
2012-08-14 16:24 ` [PATCH 15/16] openvswitch: " Sasha Levin
2012-08-14 16:24 ` [PATCH 16/16] tracing output: " Sasha Levin
2012-08-14 16:24 ` [PATCH 07/16] net,9p: " Sasha Levin
2012-08-14 16:24 ` [PATCH 14/16] net,rds: " Sasha Levin
2012-08-14 18:16 ` [PATCH 00/16] generic " J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815002834.GI25632@google.com \
--to=tj@kernel$(echo .)org \
--cc=Trond.Myklebust@netapp$(echo .)com \
--cc=aarcange@redhat$(echo .)com \
--cc=agk@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=bfields@fieldses$(echo .)org \
--cc=ccaulfie@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dev@openvswitch$(echo .)org \
--cc=dm-devel@redhat$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=ejt@redhat$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=ericvh@gmail$(echo .)com \
--cc=fweisbec@gmail$(echo .)com \
--cc=jesse@nicira$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=levinsasha928@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=lw@cn$(echo .)fujitsu.com \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mingo@elte$(echo .)hu \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=rds-devel@oss$(echo .)oracle.com \
--cc=rostedt@goodmis$(echo .)org \
--cc=snitzer@redhat$(echo .)com \
--cc=teigland@redhat$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=venkat.x.venkatsubra@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox