* [PATCH] iproute2: bridge: remove replace and change options
@ 2012-08-27 17:52 John Fastabend
2012-08-27 18:46 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: John Fastabend @ 2012-08-27 17:52 UTC (permalink / raw)
To: shemminger; +Cc: netdev
Replace and change are not supported by bridge netlink so remove it
from bridge tool options.
Signed-off-by: John Fastabend <john.r.fastabend@intel•com>
---
bridge/fdb.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/bridge/fdb.c b/bridge/fdb.c
index cee0fcd..eaefa81 100644
--- a/bridge/fdb.c
+++ b/bridge/fdb.c
@@ -26,7 +26,7 @@ int filter_index;
static void usage(void)
{
- fprintf(stderr, "Usage: bridge fdb { add | del | replace } ADDR dev DEV {self|master}\n");
+ fprintf(stderr, "Usage: bridge fdb { add | del } ADDR dev DEV {self|master}\n");
fprintf(stderr, " bridge fdb {show} [ dev DEV ]\n");
exit(-1);
}
@@ -228,11 +228,6 @@ int do_fdb(int argc, char **argv)
if (argc > 0) {
if (matches(*argv, "add") == 0)
return fdb_modify(RTM_NEWNEIGH, NLM_F_CREATE|NLM_F_EXCL, argc-1, argv+1);
- if (matches(*argv, "change") == 0)
- return fdb_modify(RTM_NEWNEIGH, NLM_F_REPLACE, argc-1, argv+1);
-
- if (matches(*argv, "replace") == 0)
- return fdb_modify(RTM_NEWNEIGH, NLM_F_CREATE|NLM_F_REPLACE, argc-1, argv+1);
if (matches(*argv, "delete") == 0)
return fdb_modify(RTM_DELNEIGH, 0, argc-1, argv+1);
if (matches(*argv, "show") == 0 ||
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iproute2: bridge: remove replace and change options
2012-08-27 17:52 [PATCH] iproute2: bridge: remove replace and change options John Fastabend
@ 2012-08-27 18:46 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2012-08-27 18:46 UTC (permalink / raw)
To: John Fastabend; +Cc: netdev
On Mon, 27 Aug 2012 10:52:31 -0700
John Fastabend <john.r.fastabend@intel•com> wrote:
> Replace and change are not supported by bridge netlink so remove it
> from bridge tool options.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel•com>
> ---
>
> bridge/fdb.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
Applied locally (will get pushed up later).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-27 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-27 17:52 [PATCH] iproute2: bridge: remove replace and change options John Fastabend
2012-08-27 18:46 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox