* [PATCH] net: sunrpc: xdr: Change message to pr_debug level
@ 2012-10-04 14:21 Fabio Estevam
[not found] ` <1349360495-29325-1-git-send-email-fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2012-10-04 14:21 UTC (permalink / raw)
To: davem; +Cc: Trond.Myklebust, marex, netdev, linux-nfs, Fabio Estevam
commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in xdr_align_pages)
has added a pr_info that floods dmesg when booting via NFS.
There is also a note in the commit log: "Warning! Contains debugging printks!"
,so change it to pr_debug instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale•com>
---
net/sunrpc/xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index e30842b..6983efc 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -749,7 +749,7 @@ static unsigned int xdr_align_pages(struct xdr_stream *xdr, unsigned int len)
xdr_shrink_pagelen(buf, buf->page_len - len);
xdr->nwords = XDR_QUADLEN(buf->len - cur);
} else
- pr_info("%s: Optimised away a data move!\n", __func__);
+ pr_debug("%s: Optimised away a data move!\n", __func__);
return len;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1349360495-29325-1-git-send-email-fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]
* Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level [not found] ` <1349360495-29325-1-git-send-email-fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org> @ 2012-10-04 14:25 ` Marek Vasut 2012-10-04 14:51 ` Myklebust, Trond 0 siblings, 1 reply; 4+ messages in thread From: Marek Vasut @ 2012-10-04 14:25 UTC (permalink / raw) To: Fabio Estevam Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-nfs-u79uwXL29TY76Z2rM5mHXA Dear Fabio Estevam, > commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in > xdr_align_pages) has added a pr_info that floods dmesg when booting via > NFS. > > There is also a note in the commit log: "Warning! Contains debugging > printks!" > > ,so change it to pr_debug instead. > > Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public•gmane.org> Reviewed-by: Marek Vasut <marex-ynQEQJNshbs@public•gmane.org> > --- > net/sunrpc/xdr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c > index e30842b..6983efc 100644 > --- a/net/sunrpc/xdr.c > +++ b/net/sunrpc/xdr.c > @@ -749,7 +749,7 @@ static unsigned int xdr_align_pages(struct xdr_stream > *xdr, unsigned int len) xdr_shrink_pagelen(buf, buf->page_len - len); > xdr->nwords = XDR_QUADLEN(buf->len - cur); > } else > - pr_info("%s: Optimised away a data move!\n", __func__); > + pr_debug("%s: Optimised away a data move!\n", __func__); > return len; > } Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net: sunrpc: xdr: Change message to pr_debug level 2012-10-04 14:25 ` Marek Vasut @ 2012-10-04 14:51 ` Myklebust, Trond 2012-10-04 14:57 ` Marek Vasut 0 siblings, 1 reply; 4+ messages in thread From: Myklebust, Trond @ 2012-10-04 14:51 UTC (permalink / raw) To: Marek Vasut, Fabio Estevam Cc: davem@davemloft•net, netdev@vger•kernel.org, linux-nfs@vger•kernel.org > -----Original Message----- > From: Marek Vasut [mailto:marex@denx•de] > Sent: Thursday, October 04, 2012 7:25 AM > To: Fabio Estevam > Cc: davem@davemloft•net; Myklebust, Trond; netdev@vger•kernel.org; > linux-nfs@vger•kernel.org > Subject: Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level > > Dear Fabio Estevam, > > > commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in > > xdr_align_pages) has added a pr_info that floods dmesg when booting > > via NFS. > > > > There is also a note in the commit log: "Warning! Contains debugging > > printks!" > > ...which meant that it contained debugging code, and was obviously not appropriate for merging upstream. The final version has already dropped the debugging printks. Trond ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level 2012-10-04 14:51 ` Myklebust, Trond @ 2012-10-04 14:57 ` Marek Vasut 0 siblings, 0 replies; 4+ messages in thread From: Marek Vasut @ 2012-10-04 14:57 UTC (permalink / raw) To: Myklebust, Trond Cc: Fabio Estevam, davem@davemloft•net, netdev@vger•kernel.org, linux-nfs@vger•kernel.org Dear Myklebust, Trond, > > -----Original Message----- > > From: Marek Vasut [mailto:marex@denx•de] > > Sent: Thursday, October 04, 2012 7:25 AM > > To: Fabio Estevam > > Cc: davem@davemloft•net; Myklebust, Trond; netdev@vger•kernel.org; > > linux-nfs@vger•kernel.org > > Subject: Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level > > > > Dear Fabio Estevam, > > > > > commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in > > > xdr_align_pages) has added a pr_info that floods dmesg when booting > > > via NFS. > > > > > > There is also a note in the commit log: "Warning! Contains debugging > > > printks!" > > ...which meant that it contained debugging code, and was obviously not > appropriate for merging upstream. The final version has already dropped > the debugging printks. Uh oh, the version with debug prints made it into -next . Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-04 14:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 14:21 [PATCH] net: sunrpc: xdr: Change message to pr_debug level Fabio Estevam
[not found] ` <1349360495-29325-1-git-send-email-fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-10-04 14:25 ` Marek Vasut
2012-10-04 14:51 ` Myklebust, Trond
2012-10-04 14:57 ` Marek Vasut
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox