From: Dan Carpenter <dan.carpenter@oracle•com>
To: yoshfuji@linux-ipv6•org
Cc: netdev@vger•kernel.org, kbuild@01•org
Subject: re: ipv6: Do not depend on rt->n in rt6_probe().
Date: Mon, 21 Jan 2013 21:28:58 +0300 [thread overview]
Message-ID: <20130121182858.GA8808@elgon.mountain> (raw)
Hello YOSHIFUJI Hideaki / 吉藤英明,
This is a semi-automatic email about new static checker warnings.
The patch 2152caea7196: "ipv6: Do not depend on rt->n in
rt6_probe()." from Jan 17, 2013, leads to the following Smatch
complaint:
net/ipv6/route.c:495 rt6_probe()
error: we previously assumed 'neigh' could be null (see line 490)
net/ipv6/route.c
489
490 if (!neigh ||
^^^^^
New test.
491 time_after(jiffies, neigh->updated + rt->rt6i_idev->cnf.rtr_probe_interval)) {
492 struct in6_addr mcaddr;
493 struct in6_addr *target;
494
495 neigh->updated = jiffies;
^^^^^^^^^^^^^^
Old dereference.
496
497 if (neigh)
^^^^^
Another new test.
regards,
dan carpenter
next reply other threads:[~2013-01-21 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 18:28 Dan Carpenter [this message]
2013-01-21 18:41 ` ipv6: Do not depend on rt->n in rt6_probe() YOSHIFUJI Hideaki
2013-01-21 19:28 ` Rate Limitation of Router Reachability Probing for possible dead routers (is Re: ipv6: Do not depend on rt->n in rt6_probe().) YOSHIFUJI Hideaki
2013-01-21 20:44 ` David Miller
2013-01-22 3:47 ` YOSHIFUJI Hideaki
2013-01-22 5:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121182858.GA8808@elgon.mountain \
--to=dan.carpenter@oracle$(echo .)com \
--cc=kbuild@01$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox