* [PATCH net-next] ipv6: Don't send packet to big messages to self
@ 2013-02-05 11:48 Steffen Klassert
2013-02-06 20:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Steffen Klassert @ 2013-02-05 11:48 UTC (permalink / raw)
To: David Miller; +Cc: Jiri Bohac, netdev
Calling icmpv6_send() on a local message size error leads to an
incorrect update of the path mtu in the case when IPsec is used.
So use ipv6_local_error() instead to notify the socket about the
error.
Reported-by: Jiri Bohac <jbohac@suse•cz>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet•com>
---
net/ipv6/ip6_output.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 7dea45a..14fee26 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -242,9 +242,8 @@ int ip6_xmit(struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6,
dst->dev, dst_output);
}
- net_dbg_ratelimited("IPv6: sending pkt_too_big to self\n");
skb->dev = dst->dev;
- icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);
+ ipv6_local_error(sk, EMSGSIZE, fl6, mtu);
IP6_INC_STATS(net, ip6_dst_idev(skb_dst(skb)), IPSTATS_MIB_FRAGFAILS);
kfree_skb(skb);
return -EMSGSIZE;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv6: Don't send packet to big messages to self
2013-02-05 11:48 [PATCH net-next] ipv6: Don't send packet to big messages to self Steffen Klassert
@ 2013-02-06 20:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-02-06 20:13 UTC (permalink / raw)
To: steffen.klassert; +Cc: jbohac, netdev
From: Steffen Klassert <steffen.klassert@secunet•com>
Date: Tue, 5 Feb 2013 12:48:05 +0100
> Calling icmpv6_send() on a local message size error leads to an
> incorrect update of the path mtu in the case when IPsec is used.
> So use ipv6_local_error() instead to notify the socket about the
> error.
>
> Reported-by: Jiri Bohac <jbohac@suse•cz>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet•com>
Applied, thanks a lot.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-06 20:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-05 11:48 [PATCH net-next] ipv6: Don't send packet to big messages to self Steffen Klassert
2013-02-06 20:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox