From: Johan Hovold <jhovold@gmail•com>
To: Ming Lei <ming.lei@canonical•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Jiri Kosina <jkosina@suse•cz>,
Alan Stern <stern@rowland•harvard.edu>,
Oliver Neukum <oneukum@suse•de>,
netdev@vger•kernel.org, linux-usb@vger•kernel.org,
linux-input@vger•kernel.org, Johan Hovold <jhovold@gmail•com>
Subject: Re: [PATCH v2 2/7] USB: serial: handle suspend failure path correctly
Date: Thu, 14 Mar 2013 12:10:10 +0100 [thread overview]
Message-ID: <20130314111010.GA15776@localhost> (raw)
In-Reply-To: <1362672924-22975-3-git-send-email-ming.lei@canonical.com>
On Fri, Mar 08, 2013 at 12:15:19AM +0800, Ming Lei wrote:
> This patch kills traffic even though type->suspend returns
> failure inside usb_serial_suspend from system sleep context
> because USB core ignores the failiure and lets system sleep
> go ahread, so the serial URB traffic need to be killed
> in this case.
>
> Cc: Johan Hovold <jhovold@gmail•com>
> Signed-off-by: Ming Lei <ming.lei@canonical•com>
> ---
> drivers/usb/serial/usb-serial.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
> index a19ed74..9d0b9c8 100644
> --- a/drivers/usb/serial/usb-serial.c
> +++ b/drivers/usb/serial/usb-serial.c
> @@ -1142,10 +1142,11 @@ int usb_serial_suspend(struct usb_interface *intf, pm_message_t message)
>
> if (serial->type->suspend) {
> r = serial->type->suspend(serial, message);
> - if (r < 0) {
> + if (r < 0 && PMSG_IS_AUTO(message)) {
> serial->suspending = 0;
> goto err_out;
> }
> + /* TODO: resume() might need to handle suspend failure */
> }
>
> for (i = 0; i < serial->num_ports; ++i) {
Sorry for the late reply.
The usb-serial subdriver suspend callbacks do not and must not return
non-zero if !PMSG_IS_AUTO(message) so adding code to handle that case
merely obfuscates this fact.
I'd rather see this documented with a comment just as Bjørn suggested
for cdc_mbim and qmi_wwan.
Thanks,
Johan
next prev parent reply other threads:[~2013-03-14 11:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 16:15 [PATCH v2 0/7] USB: don't recover device if suspend fails in system sleep Ming Lei
[not found] ` <1362672924-22975-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-03-07 16:15 ` [PATCH v2 1/7] USB: adds comment on suspend callback Ming Lei
2013-03-07 20:26 ` Alan Stern
2013-03-07 16:15 ` [PATCH v2 4/7] usbnet: cdc_mbim: comments on suspend failure Ming Lei
2013-03-07 18:08 ` Bjørn Mork
2013-03-07 16:15 ` [PATCH v2 5/7] usbnet: qmi_wwan: " Ming Lei
2013-03-07 18:08 ` Bjørn Mork
2013-03-07 16:15 ` [PATCH v2 2/7] USB: serial: handle suspend failure path correctly Ming Lei
2013-03-14 11:10 ` Johan Hovold [this message]
2013-03-15 3:04 ` Ming Lei
2013-03-07 16:15 ` [PATCH v2 3/7] USBHID: don't recover device if suspend fails in system sleep Ming Lei
2013-03-07 23:16 ` Jiri Kosina
2013-03-07 23:48 ` Greg Kroah-Hartman
2013-03-07 16:15 ` [PATCH v2 6/7] usbnet: smsc95xx: " Ming Lei
2013-03-07 16:15 ` [PATCH v2 7/7] usbnet: smsc75xx: " Ming Lei
2013-03-07 20:28 ` [PATCH v2 0/7] USB: " David Miller
2013-03-07 23:24 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 16:07 (unknown), Ming Lei
2013-03-07 16:07 ` [PATCH v2 2/7] USB: serial: handle suspend failure path correctly Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314111010.GA15776@localhost \
--to=jhovold@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jkosina@suse$(echo .)cz \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=ming.lei@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oneukum@suse$(echo .)de \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox