From: "Bjørn Mork" <bjorn@mork•no>
To: Ming Lei <ming.lei@canonical•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Jiri Kosina <jkosina@suse•cz>,
Alan Stern <stern@rowland•harvard.edu>,
Oliver Neukum <oneukum@suse•de>,
netdev@vger•kernel.org, linux-usb@vger•kernel.org,
linux-input@vger•kernel.org
Subject: Re: [PATCH v2 5/7] usbnet: qmi_wwan: comments on suspend failure
Date: Thu, 07 Mar 2013 19:08:49 +0100 [thread overview]
Message-ID: <871ubrjd5a.fsf@nemi.mork.no> (raw)
In-Reply-To: <1362672924-22975-6-git-send-email-ming.lei@canonical.com> (Ming Lei's message of "Fri, 8 Mar 2013 00:15:22 +0800")
Ming Lei <ming.lei@canonical•com> writes:
> If suspend callback fails in system sleep context, usb core will
> ignore the failure and let system sleep go ahead further, so
> this patch comments on the case and requires that both
> usbnet_suspend() and subdriver->suspend() MUST return 0 in
> system sleep context.
>
> Cc: Bjørn Mork <bjorn@mork•no>
> Signed-off-by: Ming Lei <ming.lei@canonical•com>
> ---
> drivers/net/usb/qmi_wwan.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index efb5c7c..8a60bdd 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -288,6 +288,11 @@ static int qmi_wwan_suspend(struct usb_interface *intf, pm_message_t message)
> struct qmi_wwan_state *info = (void *)&dev->data;
> int ret;
>
> + /*
> + * Both usbnet_suspend() and subdriver->suspend() MUST return 0
> + * in system sleep context, otherwise, the resume callback has
> + * to recover device from previous suspend failure.
> + */
> ret = usbnet_suspend(intf, message);
> if (ret < 0)
> goto err;
Acked-by: Bjørn Mork <bjorn@mork•no>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger•kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-03-07 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 16:15 [PATCH v2 0/7] USB: don't recover device if suspend fails in system sleep Ming Lei
2013-03-07 16:15 ` [PATCH v2 2/7] USB: serial: handle suspend failure path correctly Ming Lei
2013-03-14 11:10 ` Johan Hovold
2013-03-15 3:04 ` Ming Lei
2013-03-07 16:15 ` [PATCH v2 3/7] USBHID: don't recover device if suspend fails in system sleep Ming Lei
2013-03-07 23:16 ` Jiri Kosina
2013-03-07 23:48 ` Greg Kroah-Hartman
[not found] ` <1362672924-22975-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-03-07 16:15 ` [PATCH v2 1/7] USB: adds comment on suspend callback Ming Lei
2013-03-07 20:26 ` Alan Stern
2013-03-07 16:15 ` [PATCH v2 4/7] usbnet: cdc_mbim: comments on suspend failure Ming Lei
2013-03-07 18:08 ` Bjørn Mork
2013-03-07 16:15 ` [PATCH v2 5/7] usbnet: qmi_wwan: " Ming Lei
2013-03-07 18:08 ` Bjørn Mork [this message]
2013-03-07 16:15 ` [PATCH v2 6/7] usbnet: smsc95xx: don't recover device if suspend fails in system sleep Ming Lei
2013-03-07 16:15 ` [PATCH v2 7/7] usbnet: smsc75xx: " Ming Lei
2013-03-07 20:28 ` [PATCH v2 0/7] USB: " David Miller
2013-03-07 23:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ubrjd5a.fsf@nemi.mork.no \
--to=bjorn@mork$(echo .)no \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jkosina@suse$(echo .)cz \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=ming.lei@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oneukum@suse$(echo .)de \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox