From: Stephen Hemminger <stephen@networkplumber•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 03/10] vxlan: move IGMP join/leave to work queue
Date: Wed, 5 Jun 2013 08:42:03 -0700 [thread overview]
Message-ID: <20130605084203.77dad08a@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <kommuo$ma8$1@ger.gmane.org>
On Wed, 5 Jun 2013 06:47:52 +0000 (UTC)
Cong Wang <xiyou.wangcong@gmail•com> wrote:
> On Wed, 05 Jun 2013 at 04:24 GMT, Stephen Hemminger <stephen@networkplumber•org> wrote:
> > Do join/leave from work queue to avoid lock inversion problems
> > between normal socket and RTNL. The code comes out cleaner
> > as well.
> >
> > Uses Cong Wang's suggestion to turn refcnt into a real atomic
> > since now need to handle case where last use of socket is IGMP
> > worker.
> >
> > Also fixes race where vxlan_stop could be called after
> > device was deleted on module removal. The call to rtnl_link_unregister
> > would call dellink while vxlan device was still up. Reordering
> > the calls fixes it.
> >
>
> After the first 3 patches applied, I got:
>
> [ 55.010954] general protection fault: 0000 [#1] SMP DEBUG_PAGEALLOC
> [ 55.013309] CPU: 1 PID: 163 Comm: kworker/1:2 Not tainted
> 3.10.0-rc2+ #1150
> [ 55.013309] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
> [ 55.013309] Workqueue: events vxlan_igmp_work
> [ 55.013309] task: ffff880070eac900 ti: ffff8800716d4000 task.ti:
> ffff8800716d4000
> [ 55.013309] RIP: 0010:[<ffffffff815df704>] [<ffffffff815df704>]
> vxlan_sock_release+0x25/0x55
> [ 55.013309] RSP: 0018:ffff8800716d5cf8 EFLAGS: 00010246
> [ 55.013309] RAX: 0000000000000000 RBX: ffff88006fd7c000 RCX:
> 0000000ccee84d06
> [ 55.013309] RDX: dead000000200200 RSI: ffff880070ead048 RDI:
> ffff88006fd7c070
> [ 55.013309] RBP: ffff8800716d5d08 R08: 0000000000000000 R09:
> ffff8800716d5c48
> [ 55.013309] R10: 000000000000b6c4 R11: 000000000000b163 R12:
> ffff88006ebb7400
> [ 55.013309] R13: ffff88006fd7c000 R14: ffff8800723b4520 R15:
> 0000000000000000
> [ 55.013309] FS: 0000000000000000(0000) GS:ffff88007f800000(0000)
> knlGS:0000000000000000
> [ 55.013309] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> [ 55.013309] CR2: 00007fa99dc0a000 CR3: 0000000070c17000 CR4:
> 00000000000006e0
> [ 55.013309] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
> 0000000000000000
> [ 55.013309] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7:
> 0000000000000400
> [ 55.013309] Stack:
> [ 55.013309] ffff880070eac900 ffff880070fc0b58 ffff8800716d5d48
> ffffffff815e0a73
> [ 55.013309] 080808e0716d5d28 0000000f00000000 ffff8800714ef008
> ffff880070fc0b58
> [ 55.013309] ffff88007f9d6200 ffff88007f9d38c0 ffff8800716d5de8
> ffffffff8106872f
> [ 55.013309] Call Trace:
> [ 55.013309] [<ffffffff815e0a73>] vxlan_igmp_work+0xa8/0xcf
> [ 55.013309] [<ffffffff8106872f>] process_one_work+0x240/0x408
> [ 55.013309] [<ffffffff81068662>] ? process_one_work+0x173/0x408
> [ 55.013309] [<ffffffff81068c82>] worker_thread+0x15d/0x1f1
> [ 55.013309] [<ffffffff81068b25>] ? rescuer_thread+0x1ff/0x1ff
> [ 55.013309] [<ffffffff81070c19>] kthread+0xb1/0xb9
> [ 55.013309] [<ffffffff81070b68>] ? freezing+0x17/0x17
> [ 55.013309] [<ffffffff81976bdc>] ret_from_fork+0x7c/0xb0
> [ 55.013309] [<ffffffff81070b68>] ? freezing+0x17/0x17
>
What was the order of events (ie. what did you do to make it happen)?
next prev parent reply other threads:[~2013-06-05 15:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 4:24 [PATCH net-next 01/10] vxlan: only migrate dynamic FDB entries Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 02/10] vxlan: handle skb_clone failure Stephen Hemminger
2013-06-05 6:59 ` Cong Wang
2013-06-05 14:05 ` David Stevens
2013-06-06 0:47 ` Cong Wang
2013-06-06 1:31 ` Stephen Hemminger
2013-06-05 12:50 ` David Stevens
2013-06-05 4:24 ` [PATCH net-next 03/10] vxlan: move IGMP join/leave to work queue Stephen Hemminger
2013-06-05 6:47 ` Cong Wang
2013-06-05 7:29 ` Mike Rapoport
2013-06-05 8:00 ` Cong Wang
2013-06-05 15:41 ` Stephen Hemminger
2013-06-08 8:23 ` Mike Rapoport
2013-06-05 15:42 ` Stephen Hemminger [this message]
2013-06-06 0:49 ` Cong Wang
2013-06-05 15:37 ` [PATCH net] vxlan: fix crash on module removal Stephen Hemminger
2013-06-06 1:11 ` Cong Wang
2013-06-06 1:32 ` Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 04/10] vxlan: send notification when MAC migrates Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 05/10] vxlan: make vxlan_xmit_one void Stephen Hemminger
2013-06-05 12:54 ` David Stevens
2013-06-05 4:24 ` [PATCH net-next 06/10] vxlan: convert remotes list to list_rcu Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 07/10] vxlan: port module param should be ushort Stephen Hemminger
2013-06-05 13:35 ` Sergei Shtylyov
2013-06-05 4:24 ` [PATCH net-next 08/10] vxlan: use initializer for dummy structures Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 09/10] vxlan: whitespace cleanup Stephen Hemminger
2013-06-05 12:55 ` David Stevens
2013-06-05 4:24 ` [PATCH net-next 10/10] vxlan: version 0.2 Stephen Hemminger
2013-06-05 6:23 ` [PATCH net-next 01/10] vxlan: only migrate dynamic FDB entries Cong Wang
2013-06-06 23:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605084203.77dad08a@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox