From: Stephen Hemminger <stephen@networkplumber•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net] vxlan: fix crash on module removal
Date: Wed, 5 Jun 2013 18:32:47 -0700 [thread overview]
Message-ID: <20130605183247.28c41cc2@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <koonje$ssv$1@ger.gmane.org>
On Thu, 6 Jun 2013 01:11:11 +0000 (UTC)
Cong Wang <xiyou.wangcong@gmail•com> wrote:
> On Wed, 05 Jun 2013 at 15:37 GMT, Stephen Hemminger <stephen@networkplumber•org> wrote:
> > If vxlan is removed with active vxlan's it would crash because
> > rtnl_link_unregister (which calls vxlan_dellink), was invoked
> > before unregister_pernet_device (which calls vxlan_stop).
> >
>
> Two points:
>
> 1. There are still many others drivers calling them in such order...
> 2. The removal should be in a reverse order of creation, at least in
> theory.
>
> I mean this *might* indicate something wrong.
1. Other drivers either don't have the dependency or are broken.
It makes no sense to stop a device that is deleted.
2. The normal creation order is
vxlan_setup
vxlan_newlink
vxlan_open
next prev parent reply other threads:[~2013-06-06 1:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 4:24 [PATCH net-next 01/10] vxlan: only migrate dynamic FDB entries Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 02/10] vxlan: handle skb_clone failure Stephen Hemminger
2013-06-05 6:59 ` Cong Wang
2013-06-05 14:05 ` David Stevens
2013-06-06 0:47 ` Cong Wang
2013-06-06 1:31 ` Stephen Hemminger
2013-06-05 12:50 ` David Stevens
2013-06-05 4:24 ` [PATCH net-next 03/10] vxlan: move IGMP join/leave to work queue Stephen Hemminger
2013-06-05 6:47 ` Cong Wang
2013-06-05 7:29 ` Mike Rapoport
2013-06-05 8:00 ` Cong Wang
2013-06-05 15:41 ` Stephen Hemminger
2013-06-08 8:23 ` Mike Rapoport
2013-06-05 15:42 ` Stephen Hemminger
2013-06-06 0:49 ` Cong Wang
2013-06-05 15:37 ` [PATCH net] vxlan: fix crash on module removal Stephen Hemminger
2013-06-06 1:11 ` Cong Wang
2013-06-06 1:32 ` Stephen Hemminger [this message]
2013-06-05 4:24 ` [PATCH net-next 04/10] vxlan: send notification when MAC migrates Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 05/10] vxlan: make vxlan_xmit_one void Stephen Hemminger
2013-06-05 12:54 ` David Stevens
2013-06-05 4:24 ` [PATCH net-next 06/10] vxlan: convert remotes list to list_rcu Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 07/10] vxlan: port module param should be ushort Stephen Hemminger
2013-06-05 13:35 ` Sergei Shtylyov
2013-06-05 4:24 ` [PATCH net-next 08/10] vxlan: use initializer for dummy structures Stephen Hemminger
2013-06-05 4:24 ` [PATCH net-next 09/10] vxlan: whitespace cleanup Stephen Hemminger
2013-06-05 12:55 ` David Stevens
2013-06-05 4:24 ` [PATCH net-next 10/10] vxlan: version 0.2 Stephen Hemminger
2013-06-05 6:23 ` [PATCH net-next 01/10] vxlan: only migrate dynamic FDB entries Cong Wang
2013-06-06 23:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605183247.28c41cc2@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox