* [PATCH 6/7] drivers: ssb: Kconfig: Amend SSB_EMBEDDED dependencies
[not found] <1371477641-7989-1-git-send-email-markos.chandras@imgtec.com>
@ 2013-06-17 14:00 ` Markos Chandras
2013-06-27 11:30 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Markos Chandras @ 2013-06-17 14:00 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras, sibyte-users, netdev, Michael Buesch
SSB_EMBEDDED needs functions from driver_pcicore which are only
available if SSD_DRIVER_HOSTMODE is selected so make it
depend on that symbol.
Fixes the following linking problem:
drivers/ssb/embedded.c:202:
undefined reference to `ssb_pcicore_plat_dev_init'
drivers/built-in.o: In function `ssb_pcibios_map_irq':
drivers/ssb/embedded.c:247:
undefined reference to `ssb_pcicore_pcibios_map_irq'
Signed-off-by: Markos Chandras <markos.chandras@imgtec•com>
Acked-by: Steven J. Hill <Steven.Hill@imgtec•com>
Cc: sibyte-users@bitmover•com
Cc: netdev@vger•kernel.org
Cc: Michael Buesch <m@bues•ch>
---
drivers/ssb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 5ff3a4f..36171fd 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -144,7 +144,7 @@ config SSB_SFLASH
# Assumption: We are on embedded, if we compile the MIPS core.
config SSB_EMBEDDED
bool
- depends on SSB_DRIVER_MIPS
+ depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
default y
config SSB_DRIVER_EXTIF
--
1.8.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/7] drivers: ssb: Kconfig: Amend SSB_EMBEDDED dependencies
2013-06-17 14:00 ` [PATCH 6/7] drivers: ssb: Kconfig: Amend SSB_EMBEDDED dependencies Markos Chandras
@ 2013-06-27 11:30 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2013-06-27 11:30 UTC (permalink / raw)
To: Markos Chandras; +Cc: linux-mips, sibyte-users, netdev, Michael Buesch
On Mon, Jun 17, 2013 at 03:00:40PM +0100, Markos Chandras wrote:
> SSB_EMBEDDED needs functions from driver_pcicore which are only
> available if SSD_DRIVER_HOSTMODE is selected so make it
> depend on that symbol.
>
> Fixes the following linking problem:
>
> drivers/ssb/embedded.c:202:
> undefined reference to `ssb_pcicore_plat_dev_init'
> drivers/built-in.o: In function `ssb_pcibios_map_irq':
> drivers/ssb/embedded.c:247:
> undefined reference to `ssb_pcicore_pcibios_map_irq'
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec•com>
> Acked-by: Steven J. Hill <Steven.Hill@imgtec•com>
> Cc: sibyte-users@bitmover•com
> Cc: netdev@vger•kernel.org
> Cc: Michael Buesch <m@bues•ch>
No comments received but Florian acked it over IRC so applied.
And btw, why is sibyte-users on cc - we don't want to disrupt the silence
of that list too badly ;-)
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-27 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1371477641-7989-1-git-send-email-markos.chandras@imgtec.com>
2013-06-17 14:00 ` [PATCH 6/7] drivers: ssb: Kconfig: Amend SSB_EMBEDDED dependencies Markos Chandras
2013-06-27 11:30 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox