From: Ben Pfaff <blp@nicira•com>
To: Simon Horman <horms@verge•net.au>
Cc: dev@openvswitch•org, netdev@vger•kernel.org,
Jesse Gross <jesse@nicira•com>,
Pravin B Shelar <pshelar@nicira•com>, Ravi K <rkerur@gmail•com>,
Isaku Yamahata <yamahata@valinux•co.jp>,
Joe Stringer <joe@wand•net.nz>
Subject: Re: [PATCH v2.40 5/7] lib: Push MPLS tags in the OpenFlow 1.3 ordering
Date: Fri, 27 Sep 2013 12:47:19 -0700 [thread overview]
Message-ID: <20130927194719.GD17506@nicira.com> (raw)
In-Reply-To: <1380241116-7661-6-git-send-email-horms@verge.net.au>
On Fri, Sep 27, 2013 at 09:18:34AM +0900, Simon Horman wrote:
> From: Joe Stringer <joe@wand•net.nz>
>
> This patch modifies the push_mpls behaviour to follow the OpenFlow 1.3
> specification in the presence of VLAN tagged packets. From the spec:
>
> "Newly pushed tags should always be inserted as the outermost tag in the
> outermost valid location for that tag. When a new VLAN tag is pushed, it
> should be the outermost tag inserted, immediately after the Ethernet
> header and before other tags. Likewise, when a new MPLS tag is pushed,
> it should be the outermost tag inserted, immediately after the Ethernet
> header and before other tags."
>
> When the push_mpls action was inserted using OpenFlow 1.2, we implement
> the previous behaviour by inserting VLAN actions around the MPLS action
> in the odp translation; Pop VLAN tags before committing MPLS actions,
> and push the expected VLAN tag afterwards. The trigger condition for
> this is based on the ofpact->compat field.
>
> Signed-off-by: Joe Stringer <joe@wand•net.nz>
> Signed-off-by: Simon Horman <horms@verge•net.au>
Referring to the OF1.2 behavior as "compat behavior" makes the
difference between the two possibilities less clear than otherwise. I
would prefer to use terminology that makes the distinction obvious.
Perhaps "push mpls before vlan" or "push mpls after vlan" or something
along those lines?
Thanks,
Ben.
next prev parent reply other threads:[~2013-09-27 19:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 0:18 [PATCH v2.40 0/7] MPLS actions and matches Simon Horman
2013-09-27 0:18 ` [PATCH v2.40 1/7] odp: Only pass vlan_tci to commit_vlan_action() Simon Horman
2013-09-27 16:56 ` Ben Pfaff
2013-09-27 0:18 ` [PATCH v2.40 2/7] odp: Allow VLAN actions after MPLS actions Simon Horman
2013-09-27 19:21 ` Ben Pfaff
[not found] ` <20130927192108.GA17506-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2013-09-29 1:51 ` Joe Stringer
2013-09-29 17:05 ` Ben Pfaff
2013-09-30 1:10 ` Simon Horman
[not found] ` <1380241116-7661-1-git-send-email-horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-09-27 0:18 ` [PATCH v2.40 3/7] ofp-actions: Add OFPUTIL_OFPAT13_PUSH_MPLS Simon Horman
2013-09-27 19:30 ` Ben Pfaff
[not found] ` <20130927193010.GB17506-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2013-09-29 2:07 ` Joe Stringer
2013-09-30 1:13 ` Simon Horman
2013-09-30 2:00 ` Ben Pfaff
2013-09-27 0:18 ` [PATCH v2.40 4/7] ofp-actions: Add separate OpenFlow 1.3 action parser Simon Horman
2013-09-27 19:41 ` Ben Pfaff
[not found] ` <20130927194119.GC17506-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2013-09-30 2:12 ` Simon Horman
[not found] ` <20130930021246.GC4768-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-09-30 2:19 ` Ben Pfaff
2013-09-29 2:35 ` [PATCH v2.40 0/7] MPLS actions and matches Joe Stringer
2013-09-27 0:18 ` [PATCH v2.40 5/7] lib: Push MPLS tags in the OpenFlow 1.3 ordering Simon Horman
2013-09-27 19:47 ` Ben Pfaff [this message]
2013-09-27 0:18 ` [PATCH v2.40 6/7] datapath: Break out deacceleration portion of vlan_push Simon Horman
2013-09-27 19:48 ` Ben Pfaff
2013-09-27 21:05 ` Jesse Gross
2013-09-27 0:18 ` [PATCH v2.40 7/7] datapath: Add basic MPLS support to kernel Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927194719.GD17506@nicira.com \
--to=blp@nicira$(echo .)com \
--cc=dev@openvswitch$(echo .)org \
--cc=horms@verge$(echo .)net.au \
--cc=jesse@nicira$(echo .)com \
--cc=joe@wand$(echo .)net.nz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@nicira$(echo .)com \
--cc=rkerur@gmail$(echo .)com \
--cc=yamahata@valinux$(echo .)co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox