From: Ben Pfaff <blp@nicira•com>
To: Simon Horman <horms@verge•net.au>
Cc: dev@openvswitch•org, netdev@vger•kernel.org,
Jesse Gross <jesse@nicira•com>,
Pravin B Shelar <pshelar@nicira•com>, Ravi K <rkerur@gmail•com>,
Isaku Yamahata <yamahata@valinux•co.jp>,
Joe Stringer <joe@wand•net.nz>
Subject: Re: [PATCH v2.40 3/7] ofp-actions: Add OFPUTIL_OFPAT13_PUSH_MPLS
Date: Sun, 29 Sep 2013 19:00:51 -0700 [thread overview]
Message-ID: <20130930020051.GA5368@nicira.com> (raw)
In-Reply-To: <20130930011344.GB4768@verge.net.au>
On Mon, Sep 30, 2013 at 10:13:44AM +0900, Simon Horman wrote:
> On Fri, Sep 27, 2013 at 12:30:10PM -0700, Ben Pfaff wrote:
> > On Fri, Sep 27, 2013 at 09:18:32AM +0900, Simon Horman wrote:
> > > From: Joe Stringer <joe@wand•net.nz>
> > >
> > > This patch adds a new compatibility enum for use with MPLS, so that the
> > > differing behaviour between OpenFlow 1.2 and 1.3 can be implemented in
> > > ofproto-dpif-xlate.
> >
> > It seems a little awkward to me to do this via a new OFPACT_, mostly
> > because there isn't currently any distinction between OF1.1 and OF1.3 in
> > terms of OFPACT_ definitions. Did you consider adding a new field to
> > struct ofpact_push_mpls that would say whether the label should be added
> > before or after a VLAN tag?
>
> I think that the main reason that Joe and I (probably much more I than Joe)
> chose to use OFPACT_ the way that we did is that it seemed to be in keeping
> with the way the code already works. Clearly you don't feel that is the
> case which seems entirely reasonable to me. I'll see about re-working the
> code as you have suggested.
Thanks. I think that it will make the code easier to understand.
next prev parent reply other threads:[~2013-09-30 2:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 0:18 [PATCH v2.40 0/7] MPLS actions and matches Simon Horman
2013-09-27 0:18 ` [PATCH v2.40 1/7] odp: Only pass vlan_tci to commit_vlan_action() Simon Horman
2013-09-27 16:56 ` Ben Pfaff
2013-09-27 0:18 ` [PATCH v2.40 2/7] odp: Allow VLAN actions after MPLS actions Simon Horman
2013-09-27 19:21 ` Ben Pfaff
[not found] ` <20130927192108.GA17506-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2013-09-29 1:51 ` Joe Stringer
2013-09-29 17:05 ` Ben Pfaff
2013-09-30 1:10 ` Simon Horman
2013-09-27 0:18 ` [PATCH v2.40 5/7] lib: Push MPLS tags in the OpenFlow 1.3 ordering Simon Horman
2013-09-27 19:47 ` Ben Pfaff
2013-09-27 0:18 ` [PATCH v2.40 6/7] datapath: Break out deacceleration portion of vlan_push Simon Horman
2013-09-27 19:48 ` Ben Pfaff
2013-09-27 21:05 ` Jesse Gross
2013-09-27 0:18 ` [PATCH v2.40 7/7] datapath: Add basic MPLS support to kernel Simon Horman
[not found] ` <1380241116-7661-1-git-send-email-horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-09-27 0:18 ` [PATCH v2.40 3/7] ofp-actions: Add OFPUTIL_OFPAT13_PUSH_MPLS Simon Horman
2013-09-27 19:30 ` Ben Pfaff
[not found] ` <20130927193010.GB17506-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2013-09-29 2:07 ` Joe Stringer
2013-09-30 1:13 ` Simon Horman
2013-09-30 2:00 ` Ben Pfaff [this message]
2013-09-27 0:18 ` [PATCH v2.40 4/7] ofp-actions: Add separate OpenFlow 1.3 action parser Simon Horman
2013-09-27 19:41 ` Ben Pfaff
[not found] ` <20130927194119.GC17506-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2013-09-30 2:12 ` Simon Horman
[not found] ` <20130930021246.GC4768-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-09-30 2:19 ` Ben Pfaff
2013-09-29 2:35 ` [PATCH v2.40 0/7] MPLS actions and matches Joe Stringer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930020051.GA5368@nicira.com \
--to=blp@nicira$(echo .)com \
--cc=dev@openvswitch$(echo .)org \
--cc=horms@verge$(echo .)net.au \
--cc=jesse@nicira$(echo .)com \
--cc=joe@wand$(echo .)net.nz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@nicira$(echo .)com \
--cc=rkerur@gmail$(echo .)com \
--cc=yamahata@valinux$(echo .)co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox