From: Stephen Hemminger <stephen@networkplumber•org>
To: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
Cc: "David S . Miller" <davem@davemloft•net>,
Vlad Yasevich <vyasevic@redhat•com>,
netdev@vger•kernel.org,
Toshiaki Makita <toshiaki.makita1@gmail•com>
Subject: Re: [PATCH v2 net 1/4] bridge: Don't use VID 0 and 4095 in vlan filtering
Date: Wed, 16 Oct 2013 08:47:38 -0700 [thread overview]
Message-ID: <20131016084738.6e2eaae0@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1381910836-718-2-git-send-email-makita.toshiaki@lab.ntt.co.jp>
On Wed, 16 Oct 2013 17:07:13 +0900
Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp> wrote:
> IEEE 802.1Q says that:
> - VID 0 shall not be configured as a PVID, or configured in any Filtering
> Database entry.
> - VID 4095 shall not be configured as a PVID, or transmitted in a tag
> header. This VID value may be used to indicate a wildcard match for the VID
> in management operations or Filtering Database entries.
> (See IEEE 802.1Q-2011 6.9.1 and Table 9-2)
>
> Don't accept adding these VIDs in the vlan_filtering implementation.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
> Reviewed-by: Vlad Yasevich <vyasevic@redhat•com>
> ---
> net/bridge/br_fdb.c | 4 +-
> net/bridge/br_netlink.c | 2 +-
> net/bridge/br_vlan.c | 97 +++++++++++++++++++++++--------------------------
> 3 files changed, 49 insertions(+), 54 deletions(-)
This one looks good, thanks.
Acked-by: Stephen Hemminger <stephen@networkplumber•org>
next prev parent reply other threads:[~2013-10-16 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 8:07 [PATCH v2 net 0/4] bridge: Fix problems around the PVID Toshiaki Makita
2013-10-16 8:07 ` [PATCH v2 net 1/4] bridge: Don't use VID 0 and 4095 in vlan filtering Toshiaki Makita
2013-10-16 15:47 ` Stephen Hemminger [this message]
2013-10-16 8:07 ` [PATCH v2 net 2/4] bridge: Apply the PVID to priority-tagged frames Toshiaki Makita
2013-10-16 15:52 ` Vlad Yasevich
2013-10-16 15:55 ` Stephen Hemminger
2013-10-16 16:16 ` Vlad Yasevich
2013-10-17 12:14 ` Toshiaki Makita
2013-10-17 17:39 ` Vlad Yasevich
2013-10-18 14:01 ` Toshiaki Makita
2013-10-16 8:07 ` [PATCH v2 net 3/4] bridge: Fix the way the PVID is referenced Toshiaki Makita
2013-10-16 8:07 ` [PATCH v2 net 4/4] bridge: Fix updating FDB entries when the PVID is applied Toshiaki Makita
2013-10-16 15:57 ` Stephen Hemminger
2013-10-16 16:11 ` Vlad Yasevich
2013-10-17 12:52 ` Toshiaki Makita
2013-10-18 20:03 ` [PATCH v2 net 0/4] bridge: Fix problems around the PVID David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016084738.6e2eaae0@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=netdev@vger$(echo .)kernel.org \
--cc=toshiaki.makita1@gmail$(echo .)com \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox