From: Stephen Hemminger <stephen@networkplumber•org>
To: Jamal Hadi Salim <jhs@mojatatu•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 1/3] netconf: rename PROXY_ARP to NEIGH_PROXY
Date: Wed, 18 Dec 2013 10:06:06 -0800 [thread overview]
Message-ID: <20131218100606.4eee45fb@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <52B1D625.5060002@mojatatu.com>
On Wed, 18 Dec 2013 12:06:45 -0500
Jamal Hadi Salim <jhs@mojatatu•com> wrote:
> On 12/18/13 01:35, Stephen Hemminger wrote:
> > Use same field for both IPv4 (proxy_arp) and IPv6 (proxy_ndp)
> > so fix it before API is set to be a common name
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
> >
> > ---
> > include/uapi/linux/netconf.h | 2 +-
> > net/ipv4/devinet.c | 10 +++++-----
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > --- a/include/uapi/linux/netconf.h 2013-12-17 22:30:00.000000000 -0800
> > +++ b/include/uapi/linux/netconf.h 2013-12-17 22:31:07.973419694 -0800
> > @@ -14,7 +14,7 @@ enum {
> > NETCONFA_FORWARDING,
> > NETCONFA_RP_FILTER,
> > NETCONFA_MC_FORWARDING,
> > - NETCONFA_PROXY_ARP,
> > + NETCONFA_PROXY_NEIGH,
> > __NETCONFA_MAX
> > };
>
> Can you do this? ;-> Why not #define NETCONFA_PROXY_NEIGH to be
> NETCONFA_PROXY_ARP
>
> cheers,
> jamal
>
The patch is against un-released net-next and only changes something
that was just added.
next prev parent reply other threads:[~2013-12-18 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 6:35 [PATCH net-next 1/3] netconf: rename PROXY_ARP to NEIGH_PROXY Stephen Hemminger
2013-12-18 6:37 ` [PATCH net-next 2/3] netconf: add support for IPv6 proxy_ndp Stephen Hemminger
2013-12-20 10:05 ` Nicolas Dichtel
2013-12-22 23:03 ` David Miller
2013-12-18 6:39 ` [PATCH iproute 3/3] iproute2: add proxy_neigh attribute Stephen Hemminger
2013-12-18 17:06 ` [PATCH net-next 1/3] netconf: rename PROXY_ARP to NEIGH_PROXY Jamal Hadi Salim
2013-12-18 18:06 ` Stephen Hemminger [this message]
2013-12-20 10:02 ` Nicolas Dichtel
2013-12-22 23:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218100606.4eee45fb@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox