From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Tilman Schmidt <tilman@imap•cc>
Cc: netdev@vger•kernel.org, Paul Bolle <pebolle@tiscali•nl>,
isdn4linux@listserv•isdn4linux.de, "Keil,
Karsten" <isdn@linux-pingi•de>, Jiri Slaby <jslaby@suse•cz>
Subject: Re: [PATCH 3/4] tty: allow tty drivers to rename their device nodes
Date: Wed, 28 May 2014 13:56:56 -0700 [thread overview]
Message-ID: <20140528205656.GA3117@kroah.com> (raw)
In-Reply-To: <243519fa733359d22ce008b795f5686411e6038a.1400449372.git.tilman@imap.cc>
On Wed, May 21, 2014 at 11:39:26PM +0200, Tilman Schmidt wrote:
> From: Paul Bolle <pebolle@tiscali•nl>
>
> The device nodes for tty drivers are named using a straightforward
> scheme: tty_driver->name with an (increasing) digit appended. But the
> capi driver (a part of one of the current ISDN subsystems) requires a
> different naming scheme for its "capi_nc" tty_driver:
> /dev/capi/0
> /dev/capi/1
> [...]
Can't you just use a '!' character to represent the '/' and the tty core
will handle it all properly for you without this tty core change needed?
> So add a devnode() callback to struct tty_driver to allow tty drivers
> to use a more elaborate naming scheme. And let tty_devnode(), the
> devnode() callback for the "tty" class, call that new callback if a tty
> driver uses one. This allows the capi driver to add a callback to
> enable its scheme.
And why the sudden need for this feature, what changed in isdn to
warrant this change?
greg k-h
next prev parent reply other threads:[~2014-05-28 20:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 21:39 [PATCH 0/4] ISDN patches for net-next (resubmission) Tilman Schmidt
2014-05-21 21:39 ` [PATCH 3/4] tty: allow tty drivers to rename their device nodes Tilman Schmidt
2014-05-28 20:56 ` Greg Kroah-Hartman [this message]
2014-05-28 21:06 ` Paul Bolle
2014-05-28 21:12 ` Greg Kroah-Hartman
2014-05-28 21:17 ` Paul Bolle
2014-05-21 21:39 ` [PATCH 1/4] isdn/capi: move capi_info2str to capidrv.c Tilman Schmidt
2014-05-22 6:32 ` Karsten Keil
2014-05-22 21:38 ` Paul Bolle
2014-05-23 19:03 ` David Miller
2014-05-24 11:01 ` Karsten Keil
2014-05-24 11:43 ` Paul Bolle
2014-05-24 12:48 ` Tilman Schmidt
2014-05-24 14:14 ` Karsten Keil
2014-05-21 21:39 ` [PATCH 4/4] isdn/capi: fix (middleware) device nodes Tilman Schmidt
2014-05-21 21:39 ` [PATCH 2/4] isdn/capi: Make verbose reporting depend on capidrv Tilman Schmidt
-- strict thread matches above, loose matches on Subject: below --
2014-05-18 21:26 [PATCH 0/4] ISDN patches for net-next Tilman Schmidt
2014-05-18 21:26 ` [PATCH 3/4] tty: allow tty drivers to rename their device nodes Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528205656.GA3117@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=isdn4linux@listserv$(echo .)isdn4linux.de \
--cc=isdn@linux-pingi$(echo .)de \
--cc=jslaby@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pebolle@tiscali$(echo .)nl \
--cc=tilman@imap$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox