From: Thomas Graf <tgraf@suug•ch>
To: Ying Xue <ying.xue@windriver•com>
Cc: davem@davemloft•net, eric.dumazet@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next v3] lib/rhashtable: allow user to set the minimum shifts of shrinking
Date: Mon, 1 Sep 2014 10:41:26 +0100 [thread overview]
Message-ID: <20140901094126.GD27933@casper.infradead.org> (raw)
In-Reply-To: <54043C45.7090005@windriver.com>
On 09/01/14 at 05:28pm, Ying Xue wrote:
> Do you think it's worth replacing max() macro with max_t() regarding
> above suggestion?
Yes. max_t() is what should be used in this case.
> By the way, if the replacement should do, all max() macro in the
> lib/rhashtable.c should be replaced as well.
I think the other max() usage is fine as both arguments have a type (size_t).
prev parent reply other threads:[~2014-09-01 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 6:48 [PATCH net-next v3] lib/rhashtable: allow user to set the minimum shifts of shrinking Ying Xue
2014-09-01 9:03 ` Thomas Graf
2014-09-01 9:28 ` Ying Xue
2014-09-01 9:41 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901094126.GD27933@casper.infradead.org \
--to=tgraf@suug$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox