From: Jiri Pirko <jiri@resnulli•us>
To: "Rosen, Rami" <rami.rosen@intel•com>
Cc: Scott Feldman <sfeldma@gmail•com>,
Netdev <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
"idosch@mellanox•com" <idosch@mellanox•com>,
"eladr@mellanox•com" <eladr@mellanox•com>,
"ogerlitz@mellanox•com" <ogerlitz@mellanox•com>,
Roopa Prabhu <roopa@cumulusnetworks•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Thomas Graf <tgraf@suug•ch>,
Alexei Starovoitov <ast@plumgrid•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Daniel Borkmann <daniel@iogearbox•net>,
john fastabend <john.fastabend@gmail•com>,
"simon.horman@netronome•com" <simon.horman@netronome•com>,
John Linville <linville@tuxdriver•com>,
Andy Gospodarek <andy@greyhouse•net>,
Shrijeet Mukherjee <shm@cumulusnetworks•com>,
"nhorman@tuxdriver•com" <nhorman@tuxdriver•com>,
Jiri Pirko <jiri@mellanox•com>
Subject: Re: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support
Date: Tue, 28 Jul 2015 20:06:25 +0200 [thread overview]
Message-ID: <20150728180625.GA2046@nanopsycho> (raw)
In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F919405E0B@HASMSX110.ger.corp.intel.com>
Mon, Jul 27, 2015 at 08:17:22AM CEST, rami.rosen@intel•com wrote:
>Hi, Jiri,
>
>Keep on the good work!
>
>The .func member of the mlxsw_rx_listener object has this prototype:
>void (*func)(struct sk_buff *skb, u8 local_port, u16 trap_id, void *priv);
>
>Is the trap_id parameter needed ?
>In the three use cases of .func, which are either mlxsw_emad_rx_listener_func(), mlxsw_core_event_listener_func(), or mlxsw_sx_rx_listener_func(), this parameter is not used at all.
You are right. We intended to use MLXSW_TRAP_ID_DONT_CARE and use
trap_id in the callback, but when user registers a callback for exact
trap_id, this is not needed. Will remove in v2.
Thanks.
next prev parent reply other threads:[~2015-07-28 18:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 15:43 [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers Jiri Pirko
2015-07-23 15:43 ` [patch net-next 1/4] mlxsw: Introduce Mellanox switch driver core Jiri Pirko
2015-07-23 15:43 ` [patch net-next 2/4] mlxsw: Add PCI bus implementation Jiri Pirko
2015-07-24 4:52 ` Scott Feldman
2015-07-24 5:30 ` Jiri Pirko
2015-07-26 5:15 ` Scott Feldman
2015-07-26 6:49 ` Jiri Pirko
2015-07-23 15:43 ` [patch net-next 3/4] mlxsw: Add interface to access registers and process events Jiri Pirko
2015-07-23 21:12 ` Andy Gospodarek
2015-07-24 5:24 ` Jiri Pirko
2015-07-24 12:09 ` Andy Gospodarek
2015-07-24 5:13 ` Scott Feldman
2015-07-24 5:18 ` Jiri Pirko
2015-07-24 6:48 ` Elad Raz
2015-07-23 15:43 ` [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support Jiri Pirko
2015-07-23 17:19 ` Alexander Duyck
2015-07-23 19:42 ` Jiri Pirko
2015-07-26 2:45 ` Scott Feldman
2015-07-26 7:10 ` Jiri Pirko
2015-07-26 17:14 ` Jiri Pirko
2015-07-27 6:17 ` Rosen, Rami
2015-07-28 18:06 ` Jiri Pirko [this message]
2015-07-24 0:03 ` [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers Scott Feldman
2015-07-24 0:38 ` Rustad, Mark D
2015-07-24 5:38 ` Jiri Pirko
2015-07-27 6:51 ` David Miller
2015-07-27 20:21 ` Scott Feldman
2015-07-27 20:27 ` Jiri Pirko
2015-07-27 21:21 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728180625.GA2046@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=andy@greyhouse$(echo .)net \
--cc=ast@plumgrid$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eladr@mellanox$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=rami.rosen@intel$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox