From: Alexander Duyck <alexander.duyck@gmail•com>
To: Jiri Pirko <jiri@resnulli•us>, netdev@vger•kernel.org
Cc: davem@davemloft•net, idosch@mellanox•com, eladr@mellanox•com,
ogerlitz@mellanox•com, sfeldma@gmail•com,
roopa@cumulusnetworks•com, f.fainelli@gmail•com, tgraf@suug•ch,
ast@plumgrid•com, jhs@mojatatu•com, daniel@iogearbox•net,
john.fastabend@gmail•com, simon.horman@netronome•com,
linville@tuxdriver•com, andy@greyhouse•net,
shm@cumulusnetworks•com, nhorman@tuxdriver•com,
Jiri Pirko <jiri@mellanox•com>
Subject: Re: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support
Date: Thu, 23 Jul 2015 10:19:46 -0700 [thread overview]
Message-ID: <55B12232.1020000@gmail.com> (raw)
In-Reply-To: <1437666216-3149-5-git-send-email-jiri@resnulli.us>
On 07/23/2015 08:43 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox•com>
>
> Benefit from the previously introduced Mellanox Switch infrastructure and
> add driver for SwitchX-2 ASIC. Note that this driver is very simple now.
> It implements bare minimum for getting device to work on slow-path.
> Fast-path offload functionality is going to be added soon.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
> Signed-off-by: Ido Schimmel <idosch@mellanox•com>
> Signed-off-by: Elad Raz <eladr@mellanox•com>
> ---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 11 +
> drivers/net/ethernet/mellanox/mlxsw/Makefile | 2 +
> drivers/net/ethernet/mellanox/mlxsw/core.h | 2 +
> drivers/net/ethernet/mellanox/mlxsw/pci.c | 3 +
> drivers/net/ethernet/mellanox/mlxsw/pci.h | 1 +
> drivers/net/ethernet/mellanox/mlxsw/port.h | 4 +
> drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 1541 ++++++++++++++++++++++++
> drivers/net/ethernet/mellanox/mlxsw/txheader.h | 80 ++
> 8 files changed, 1644 insertions(+)
> create mode 100644 drivers/net/ethernet/mellanox/mlxsw/switchx2.c
> create mode 100644 drivers/net/ethernet/mellanox/mlxsw/txheader.h
>
<snip>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c
> new file mode 100644
> index 0000000..15dc53b
> --- /dev/null
> +++ b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c
> @@ -0,0 +1,1541 @@
> +/*
> + * drivers/net/ethernet/mellanox/mlxsw/switchx2.c
> + * Copyright (c) 2015 Mellanox Technologies. All rights reserved.
> + * Copyright (c) 2015 Jiri Pirko <jiri@mellanox•com>
> + * Copyright (c) 2015 Ido Schimmel <idosch@mellanox•com>
> + * Copyright (c) 2015 Elad Raz <eladr@mellanox•com>
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + *
> + * 1. Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * 3. Neither the names of the copyright holders nor the names of its
> + * contributors may be used to endorse or promote products derived from
> + * this software without specific prior written permission.
> + *
> + * Alternatively, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") version 2 as published by the Free
> + * Software Foundation.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/types.h>
> +#include <linux/netdevice.h>
> +#include <linux/etherdevice.h>
> +#include <linux/slab.h>
> +#include <linux/device.h>
> +#include <linux/skbuff.h>
> +#include <linux/if_vlan.h>
> +#include <net/switchdev.h>
> +#include <generated/utsrelease.h>
> +
> +#include "core.h"
> +#include "reg.h"
> +#include "port.h"
> +#include "trap.h"
> +#include "txheader.h"
> +
> +static const char mlxsw_sx_driver_name[] = "mlxsw_switchx2";
> +static const char mlxsw_sx_driver_version[] = "1.0";
> +
> +struct mlxsw_sx_port;
> +
> +#define MLXSW_SW_HW_ID_LEN 6
> +
> +struct mlxsw_sx {
> + struct mlxsw_sx_port **ports;
> + struct mlxsw_core *core;
> + const struct mlxsw_bus_info *bus_info;
> + u8 hw_id[MLXSW_SW_HW_ID_LEN];
> +};
> +
> +struct mlxsw_sx_port_pcpu_stats {
> + u64 rx_packets;
> + u64 rx_bytes;
> + u64 tx_packets;
> + u64 tx_bytes;
> + struct u64_stats_sync syncp;
> + u32 tx_dropped;
> +};
> +
It seems like this is the second time I have seen someone have to invent
a new pcpu stats to add tx_dropped. Maybe you should look at adding
tx_dropped to pcpu_sw_netstats and just use that.
next prev parent reply other threads:[~2015-07-23 17:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 15:43 [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers Jiri Pirko
2015-07-23 15:43 ` [patch net-next 1/4] mlxsw: Introduce Mellanox switch driver core Jiri Pirko
2015-07-23 15:43 ` [patch net-next 2/4] mlxsw: Add PCI bus implementation Jiri Pirko
2015-07-24 4:52 ` Scott Feldman
2015-07-24 5:30 ` Jiri Pirko
2015-07-26 5:15 ` Scott Feldman
2015-07-26 6:49 ` Jiri Pirko
2015-07-23 15:43 ` [patch net-next 3/4] mlxsw: Add interface to access registers and process events Jiri Pirko
2015-07-23 21:12 ` Andy Gospodarek
2015-07-24 5:24 ` Jiri Pirko
2015-07-24 12:09 ` Andy Gospodarek
2015-07-24 5:13 ` Scott Feldman
2015-07-24 5:18 ` Jiri Pirko
2015-07-24 6:48 ` Elad Raz
2015-07-23 15:43 ` [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support Jiri Pirko
2015-07-23 17:19 ` Alexander Duyck [this message]
2015-07-23 19:42 ` Jiri Pirko
2015-07-26 2:45 ` Scott Feldman
2015-07-26 7:10 ` Jiri Pirko
2015-07-26 17:14 ` Jiri Pirko
2015-07-27 6:17 ` Rosen, Rami
2015-07-28 18:06 ` Jiri Pirko
2015-07-24 0:03 ` [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers Scott Feldman
2015-07-24 0:38 ` Rustad, Mark D
2015-07-24 5:38 ` Jiri Pirko
2015-07-27 6:51 ` David Miller
2015-07-27 20:21 ` Scott Feldman
2015-07-27 20:27 ` Jiri Pirko
2015-07-27 21:21 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B12232.1020000@gmail.com \
--to=alexander.duyck@gmail$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=ast@plumgrid$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eladr@mellanox$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox