From: Andrew Lunn <andrew-g2DYL2Zd6BY@public•gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>
Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public•gmane.org,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public•gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
sgoutham-YGCgFSpz5w/QT0dZR+AlfA@public•gmane.org,
rric-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org,
frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public•gmane.org,
isubramanian-qTEPVZfXA3Y@public•gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org,
leoli-KZfg59tc24xl57MIdRCFDg@public•gmane.org,
kchudgar-qTEPVZfXA3Y@public•gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org
Subject: Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes
Date: Fri, 25 Sep 2015 00:26:54 +0200 [thread overview]
Message-ID: <20150924222654.GG20825@lunn.ch> (raw)
In-Reply-To: <20150924.151554.619662567057050978.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Thu, Sep 24, 2015 at 03:15:54PM -0700, David Miller wrote:
> From: Andrew Lunn <andrew-g2DYL2Zd6BY@public•gmane.org>
> Date: Thu, 24 Sep 2015 23:57:31 +0200
>
> > I built the FEC driver as a module, and it won't unload:
> >
> > kernel:unregister_netdevice: waiting for eth1 to become free. Usage count = 1
> > unregister_netdevice: waiting for eth1 to become free. Usage count = 1
> >
> > i assume because DSA holds a reference. I've not tried a fully module
> > build, DSA has issues with that.
> >
> > Tested-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public•gmane.org>
>
> So, is this a regression?
Sorry, worded that badly. Since DSA is still active, it should not be
possible to unload the FEC driver. DSA should have a reference to it,
and mdio-mux also should have a reference to the mdio bus of the FEC
driver.
As Russell requested, i will re-test without his patches, just to make
sure.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-24 22:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 19:17 [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes Russell King - ARM Linux
2015-09-24 19:18 ` [PATCH 1/9] phy: fix of_mdio_find_bus() device refcount leak Russell King
2015-09-24 19:18 ` [PATCH 2/9] net: dsa: " Russell King
2015-09-24 19:18 ` [PATCH 3/9] phy: fix mdiobus module safety Russell King
2015-09-24 19:18 ` [PATCH 4/9] phy: add proper phy struct device refcounting Russell King
2015-09-24 19:18 ` [PATCH 5/9] of_mdio: fix MDIO phy " Russell King
2015-09-24 19:18 ` [PATCH 6/9] net: fix phy refcounting in a bunch of drivers Russell King
2015-09-24 19:18 ` [PATCH 7/9] phy: fixed-phy: properly validate phy in fixed_phy_update_state() Russell King
2015-09-24 19:18 ` [PATCH 8/9] phy: add phy_device_remove() Russell King
2015-09-24 19:19 ` [PATCH 9/9] net: fix net_device refcounting Russell King
2015-09-24 21:57 ` [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes Andrew Lunn
2015-09-24 22:15 ` Russell King - ARM Linux
[not found] ` <20150924221541.GF21513-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-09-24 22:50 ` Andrew Lunn
2015-09-24 23:33 ` Russell King - ARM Linux
2015-09-24 22:15 ` David Miller
[not found] ` <20150924.151554.619662567057050978.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-09-24 22:26 ` Andrew Lunn [this message]
[not found] ` <20150924222654.GG20825-g2DYL2Zd6BY@public.gmane.org>
2015-09-24 22:51 ` David Miller
2015-09-24 23:12 ` Russell King - ARM Linux
2015-09-25 1:39 ` Florian Fainelli
[not found] ` <5604A5EC.7060401-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-25 6:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924222654.GG20825@lunn.ch \
--to=andrew-g2dyl2zd6by@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=isubramanian-qTEPVZfXA3Y@public$(echo .)gmane.org \
--cc=kchudgar-qTEPVZfXA3Y@public$(echo .)gmane.org \
--cc=leoli-KZfg59tc24xl57MIdRCFDg@public$(echo .)gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public$(echo .)gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public$(echo .)gmane.org \
--cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
--cc=rric-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
--cc=sgoutham-YGCgFSpz5w/QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox