From: Andrew Lunn <andrew@lunn•ch>
To: Russell King - ARM Linux <linux@arm•linux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
David Miller <davem@davemloft•net>,
Thomas Petazzoni <thomas.petazzoni@free-electrons•com>,
devicetree@vger•kernel.org, Sunil Goutham <sgoutham@cavium•com>,
Robert Richter <rric@kernel•org>,
Frank Rowand <frowand.list@gmail•com>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
Rob Herring <robh+dt@kernel•org>,
Michal Simek <michal.simek@xilinx•com>,
netdev@vger•kernel.org,
Soren Brinkmann <soren.brinkmann@xilinx•com>,
Iyappan Subramanian <isubramanian@apm•com>,
Grant Likely <grant.likely@linaro•org>,
Li Yang <leoli@freescale•com>, Keyur Chudgar <kchudgar@apm•com>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes
Date: Thu, 24 Sep 2015 23:57:31 +0200 [thread overview]
Message-ID: <20150924215731.GE20825@lunn.ch> (raw)
In-Reply-To: <20150924191754.GC21513@n2100.arm.linux.org.uk>
...
> While looking at the DSA code, I noticed we have a
> of_find_net_device_by_node(), and it looks like users of that are
> similarly buggy - it looks like net/dsa/dsa.c is the only user. Fix
> that too.
...
> The mdiobus code also suffered from the same kind of leak, but thankfully
> this only happened in one place - the mdio-mux code.
Hi Russell
I tested both of these with my board. It is a Freescale Vybrid, using
the FEC ethernet driver, and i have three switches attached, using
mdio-mux to give three mdio busses.
No obvious regressions, my board boots, the switches are all present
and correct. I built the FEC driver as a module, and it won't unload:
kernel:unregister_netdevice: waiting for eth1 to become free. Usage count = 1
unregister_netdevice: waiting for eth1 to become free. Usage count = 1
i assume because DSA holds a reference. I've not tried a fully module
build, DSA has issues with that.
Tested-by: Andrew Lunn <andrew@lunn•ch>
Thanks
Andrew
next prev parent reply other threads:[~2015-09-24 21:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 19:17 [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes Russell King - ARM Linux
2015-09-24 19:18 ` [PATCH 1/9] phy: fix of_mdio_find_bus() device refcount leak Russell King
2015-09-24 19:18 ` [PATCH 2/9] net: dsa: " Russell King
2015-09-24 19:18 ` [PATCH 3/9] phy: fix mdiobus module safety Russell King
2015-09-24 19:18 ` [PATCH 4/9] phy: add proper phy struct device refcounting Russell King
2015-09-24 19:18 ` [PATCH 5/9] of_mdio: fix MDIO phy " Russell King
2015-09-24 19:18 ` [PATCH 6/9] net: fix phy refcounting in a bunch of drivers Russell King
2015-09-24 19:18 ` [PATCH 7/9] phy: fixed-phy: properly validate phy in fixed_phy_update_state() Russell King
2015-09-24 19:18 ` [PATCH 8/9] phy: add phy_device_remove() Russell King
2015-09-24 19:19 ` [PATCH 9/9] net: fix net_device refcounting Russell King
2015-09-24 21:57 ` Andrew Lunn [this message]
2015-09-24 22:15 ` [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes Russell King - ARM Linux
[not found] ` <20150924221541.GF21513-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-09-24 22:50 ` Andrew Lunn
2015-09-24 23:33 ` Russell King - ARM Linux
2015-09-24 22:15 ` David Miller
[not found] ` <20150924.151554.619662567057050978.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-09-24 22:26 ` Andrew Lunn
[not found] ` <20150924222654.GG20825-g2DYL2Zd6BY@public.gmane.org>
2015-09-24 22:51 ` David Miller
2015-09-24 23:12 ` Russell King - ARM Linux
2015-09-25 1:39 ` Florian Fainelli
[not found] ` <5604A5EC.7060401-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-25 6:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924215731.GE20825@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=grant.likely@linaro$(echo .)org \
--cc=isubramanian@apm$(echo .)com \
--cc=kchudgar@apm$(echo .)com \
--cc=leoli@freescale$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=michal.simek@xilinx$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh+dt@kernel$(echo .)org \
--cc=rric@kernel$(echo .)org \
--cc=sgoutham@cavium$(echo .)com \
--cc=soren.brinkmann@xilinx$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox