From: "Amir Vadai\"" <amir@vadai•me>
To: John Fastabend <john.fastabend@gmail•com>
Cc: ogerlitz@mellanox•com, jiri@resnulli•us, jhs@mojatatu•com,
jeffrey.t.kirsher@intel•com, netdev@vger•kernel.org,
davem@davemloft•net
Subject: Re: [net-next PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs
Date: Thu, 4 Feb 2016 15:18:57 +0200 [thread overview]
Message-ID: <20160204131857.GA1458@office.Home> (raw)
In-Reply-To: <20160203092837.1356.8823.stgit@john-Precision-Tower-5810>
On Wed, Feb 03, 2016 at 01:28:37AM -0800, John Fastabend wrote:
> This patch allows netdev drivers to consume cls_u32 offloads via
> the ndo_setup_tc ndo op.
>
> This works aligns with how network drivers have been doing qdisc
> offloads for mqprio.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel•com>
> ---
> include/linux/netdevice.h | 6 +++-
> include/net/pkt_cls.h | 33 ++++++++++++++++++++
> net/sched/cls_u32.c | 73 ++++++++++++++++++++++++++++++++++++++++++++-
> 3 files changed, 109 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 9090ff7..861ce67 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -778,17 +778,21 @@ static inline bool netdev_phys_item_id_same(struct netdev_phys_item_id *a,
> typedef u16 (*select_queue_fallback_t)(struct net_device *dev,
> struct sk_buff *skb);
>
> -/* This structure holds attributes of qdisc and classifiers
> +/* These structures hold the attributes of qdisc and classifiers
> * that are being passed to the netdevice through the setup_tc op.
> */
> enum {
> TC_SETUP_MQPRIO,
> + TC_SETUP_CLSU32,
> };
>
> +struct tc_cls_u32_offload;
> +
> struct tc_to_netdev {
> unsigned int type;
> union {
> u8 tc;
> + struct tc_cls_u32_offload *cls_u32;
> };
> };
>
> diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
> index bc49967..0bd12cd 100644
> --- a/include/net/pkt_cls.h
> +++ b/include/net/pkt_cls.h
> @@ -358,4 +358,37 @@ tcf_match_indev(struct sk_buff *skb, int ifindex)
> }
> #endif /* CONFIG_NET_CLS_IND */
>
> +struct tc_cls_u32_knode {
> + struct tcf_exts *exts;
> + u8 fshift;
> + u32 handle;
> + u32 val;
> + u32 mask;
> + u32 link_handle;
> + struct tc_u32_sel *sel;
> +};
> +
> +struct tc_cls_u32_hnode {
> + u32 handle;
> + u32 prio;
> + unsigned int divisor;
> +};
> +
> +enum {
> + TC_CLSU32_NEW_KNODE,
TC_CLSU32_NEW_KNODE is never used
[...]
next prev parent reply other threads:[~2016-02-04 13:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 9:27 [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe John Fastabend
2016-02-03 9:27 ` [net-next PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter John Fastabend
2016-02-03 9:58 ` kbuild test robot
2016-02-03 9:59 ` kbuild test robot
2016-02-03 11:44 ` kbuild test robot
2016-02-03 9:28 ` [net-next PATCH 2/7] net: rework setup_tc ndo op to consume general tc operand John Fastabend
2016-02-03 9:28 ` [net-next PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs John Fastabend
2016-02-03 10:14 ` kbuild test robot
2016-02-04 13:18 ` Amir Vadai" [this message]
2016-02-09 11:09 ` Fastabend, John R
2016-02-03 9:28 ` [net-next PATCH 4/7] net: add tc offload feature flag John Fastabend
2016-02-03 9:29 ` [net-next PATCH 5/7] net: tc: helper functions to query action types John Fastabend
2016-02-03 9:29 ` [net-next PATCH 6/7] net: ixgbe: add minimal parser details for ixgbe John Fastabend
2016-02-03 9:29 ` [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload John Fastabend
2016-02-03 10:07 ` Amir Vadai"
2016-02-03 10:26 ` John Fastabend
2016-02-03 12:46 ` Jamal Hadi Salim
2016-02-03 19:02 ` Fastabend, John R
2016-02-09 11:30 ` Fastabend, John R
2016-02-04 7:30 ` Amir Vadai"
2016-02-04 8:23 ` Fastabend, John R
2016-02-04 12:12 ` Amir Vadai"
2016-02-09 11:27 ` Fastabend, John R
2016-02-03 10:11 ` [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe Amir Vadai"
2016-02-03 10:21 ` John Fastabend
2016-02-03 10:31 ` Or Gerlitz
2016-02-03 12:21 ` Jamal Hadi Salim
2016-02-03 18:48 ` Fastabend, John R
2016-02-04 13:12 ` Jamal Hadi Salim
2016-02-09 11:24 ` Fastabend, John R
2016-02-09 12:20 ` Jamal Hadi Salim
2016-02-04 9:16 ` Jiri Pirko
2016-02-04 23:19 ` Pablo Neira Ayuso
2016-02-09 11:06 ` Fastabend, John R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204131857.GA1458@office.Home \
--to=amir@vadai$(echo .)me \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox