From: John Fastabend <john.fastabend@gmail•com>
To: "Amir Vadai\"" <amir@vadai•me>
Cc: ogerlitz@mellanox•com, jiri@resnulli•us, jhs@mojatatu•com,
jeffrey.t.kirsher@intel•com, netdev@vger•kernel.org,
davem@davemloft•net
Subject: Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe
Date: Wed, 03 Feb 2016 02:21:29 -0800 [thread overview]
Message-ID: <56B1D4A9.3050801@gmail.com> (raw)
In-Reply-To: <20160203101109.GB20905@office.Home>
On 16-02-03 02:11 AM, Amir Vadai" wrote:
> On Wed, Feb 03, 2016 at 01:27:32AM -0800, John Fastabend wrote:
>> This extends the setup_tc framework so it can support more than just
>> the mqprio offload and push other classifiers and qdiscs into the
>> hardware. The series here targets the u32 classifier and ixgbe
>> driver. I worked out the u32 classifier because it is protocol
>> oblivious and aligns with multiple hardware devices I have access
>> to. I did an initial implementation on ixgbe because (a) I have one
>> in my box (b) its a stable driver and (c) it is relatively simple
>> compared to the other devices I have here but still has enough
>> flexibility to exercise the features of cls_u32.
>>
>> I intentionally limited the scope of this series to the basic
>> feature set. Specifically this uses a 'big hammer' feature bit
>> to do the offload or not. If the bit is set you get offloaded rules
>> if it is not then rules will not be offloaded. If we can agree on
>> this patch series there are some more patches on my queue we can
>> talk about to make the offload decision per rule using flags similar
>> to how we do l2 mac updates. Additionally the error strategy can
>> be improved to be hard aborting, log and continue, etc. I think
>> these are nice to have improvements but shouldn't block this series.
>>
>> Also by adding get_parse_graph and set_parse_graph attributes as
>> in my previous flow_api work we can build programmable devices
>> and programmatically learn when rules can or can not be loaded
>> into the hardware. Again future work.
>>
>> Any comments/feedback appreciated.
>>
>> Thanks,
>> John
>>
>> ---
>>
>> John Fastabend (7):
>> net: rework ndo tc op to consume additional qdisc handle parameter
>> net: rework setup_tc ndo op to consume general tc operand
>> net: sched: add cls_u32 offload hooks for netdevs
>> net: add tc offload feature flag
>> net: tc: helper functions to query action types
>> net: ixgbe: add minimal parser details for ixgbe
>> net: ixgbe: add support for tc_u32 offload
>>
>
> Hi John,
>
> Nice work :)
Thanks, we will need at least a v2 to fixup some build errors
with various compile flags caught by build_bot and missed by me.
>
> I will add mlx5 support, and see if can live with u32. If not - will
> add flower support too.
That would be great.
Thanks
.John
>
> Amir
>
next prev parent reply other threads:[~2016-02-03 10:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 9:27 [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe John Fastabend
2016-02-03 9:27 ` [net-next PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter John Fastabend
2016-02-03 9:58 ` kbuild test robot
2016-02-03 9:59 ` kbuild test robot
2016-02-03 11:44 ` kbuild test robot
2016-02-03 9:28 ` [net-next PATCH 2/7] net: rework setup_tc ndo op to consume general tc operand John Fastabend
2016-02-03 9:28 ` [net-next PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs John Fastabend
2016-02-03 10:14 ` kbuild test robot
2016-02-04 13:18 ` Amir Vadai"
2016-02-09 11:09 ` Fastabend, John R
2016-02-03 9:28 ` [net-next PATCH 4/7] net: add tc offload feature flag John Fastabend
2016-02-03 9:29 ` [net-next PATCH 5/7] net: tc: helper functions to query action types John Fastabend
2016-02-03 9:29 ` [net-next PATCH 6/7] net: ixgbe: add minimal parser details for ixgbe John Fastabend
2016-02-03 9:29 ` [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload John Fastabend
2016-02-03 10:07 ` Amir Vadai"
2016-02-03 10:26 ` John Fastabend
2016-02-03 12:46 ` Jamal Hadi Salim
2016-02-03 19:02 ` Fastabend, John R
2016-02-09 11:30 ` Fastabend, John R
2016-02-04 7:30 ` Amir Vadai"
2016-02-04 8:23 ` Fastabend, John R
2016-02-04 12:12 ` Amir Vadai"
2016-02-09 11:27 ` Fastabend, John R
2016-02-03 10:11 ` [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe Amir Vadai"
2016-02-03 10:21 ` John Fastabend [this message]
2016-02-03 10:31 ` Or Gerlitz
2016-02-03 12:21 ` Jamal Hadi Salim
2016-02-03 18:48 ` Fastabend, John R
2016-02-04 13:12 ` Jamal Hadi Salim
2016-02-09 11:24 ` Fastabend, John R
2016-02-09 12:20 ` Jamal Hadi Salim
2016-02-04 9:16 ` Jiri Pirko
2016-02-04 23:19 ` Pablo Neira Ayuso
2016-02-09 11:06 ` Fastabend, John R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B1D4A9.3050801@gmail.com \
--to=john.fastabend@gmail$(echo .)com \
--cc=amir@vadai$(echo .)me \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox