From: Jonathan Corbet <corbet@lwn•net>
To: Justin Keller <justincompsci@gmail•com>
Cc: linux-kernel@vger•kernel.org, isdn@linux-pingi•de,
netdev@vger•kernel.org
Subject: Re: possible patch
Date: Wed, 10 Feb 2016 18:25:35 -0700 [thread overview]
Message-ID: <20160210182535.5d46bbca@lwn.net> (raw)
In-Reply-To: <CALah4Nc5Bx6FYfSnQWNaSd3YpurhKU1viqZx1KdU_M6sO0cG2Q@mail.gmail.com>
On Wed, 10 Feb 2016 19:49:11 -0500
Justin Keller <justincompsci@gmail•com> wrote:
> I am new to submitting patches, so sorry if I am doing it wrong. My idea was
> to change line 147 in drivers/isdn/pcbit/callbacks.c from
> if (cbdata->data.setup.CallingPN == NULL) {
>
> to
>
> if (cbdata->data.setup.CallingPN == NULL ||
> sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {
If you want to patch the kernel, the best way to describe what you want to
do is to ... send a patch.
Before you do so, though:
- Please read the available documentation, including SubmittingPatches and
development-process/*
- Prepare a proper changelog saying *why* you want to make this change.
You are trying to change the ISDN subsystem, which is pretty static
these days; what current problem are you running into that makes you
think this change needs to be applied to the kernel?
Thanks,
jon
prev parent reply other threads:[~2016-02-11 1:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 0:49 possible patch Justin Keller
2016-02-11 1:25 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210182535.5d46bbca@lwn.net \
--to=corbet@lwn$(echo .)net \
--cc=isdn@linux-pingi$(echo .)de \
--cc=justincompsci@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox