* possible patch
@ 2016-02-11 0:49 Justin Keller
2016-02-11 1:25 ` Jonathan Corbet
0 siblings, 1 reply; 2+ messages in thread
From: Justin Keller @ 2016-02-11 0:49 UTC (permalink / raw)
To: linux-kernel, isdn, netdev
Hello,
I am new to submitting patches, so sorry if I am doing it wrong. My idea was
to change line 147 in drivers/isdn/pcbit/callbacks.c from
if (cbdata->data.setup.CallingPN == NULL) {
to
if (cbdata->data.setup.CallingPN == NULL ||
sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {
Justin Keller
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: possible patch
2016-02-11 0:49 possible patch Justin Keller
@ 2016-02-11 1:25 ` Jonathan Corbet
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2016-02-11 1:25 UTC (permalink / raw)
To: Justin Keller; +Cc: linux-kernel, isdn, netdev
On Wed, 10 Feb 2016 19:49:11 -0500
Justin Keller <justincompsci@gmail•com> wrote:
> I am new to submitting patches, so sorry if I am doing it wrong. My idea was
> to change line 147 in drivers/isdn/pcbit/callbacks.c from
> if (cbdata->data.setup.CallingPN == NULL) {
>
> to
>
> if (cbdata->data.setup.CallingPN == NULL ||
> sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {
If you want to patch the kernel, the best way to describe what you want to
do is to ... send a patch.
Before you do so, though:
- Please read the available documentation, including SubmittingPatches and
development-process/*
- Prepare a proper changelog saying *why* you want to make this change.
You are trying to change the ISDN subsystem, which is pretty static
these days; what current problem are you running into that makes you
think this change needs to be applied to the kernel?
Thanks,
jon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-11 1:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11 0:49 possible patch Justin Keller
2016-02-11 1:25 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox