From: Andrew Lunn <andrew@lunn•ch>
To: Vishal Thanki <vishalthanki@gmail•com>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
Matus Ujhelyi <ujhelyi.m@gmail•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH] net: phy: at803x: Add support to control PHY LEDs
Date: Thu, 17 Mar 2016 18:51:52 +0100 [thread overview]
Message-ID: <20160317175152.GG26019@lunn.ch> (raw)
In-Reply-To: <CAC3a_SD=chB8pPpdRm8scztJ4592J26_PmhbUkLmbE3=DCmX-w@mail.gmail.com>
> I agree with the idea of making a generic callback in phy_driver so
> that other PHYs
> can use it. However I think these LEDs are tightly coupled with PHYs and it
> would not make much sense to expose them via LED subsystem as they
> cannot be controlled individually IMHO.
They might not be on/off controllable individually, but you can often
set them to show Packet RX, Packet TX, Link, speed, etc, in a
reasonably flexible way. So you could have LED triggers mapping to
these functionalities. The user can then pick the trigger for the LED.
Actually, the data sheet says:
2.3.4 LED Interface
The LED interface can either be controlled by the PHY or controlled
manually, independent of the state of the PHY. Two status LEDs are
available. These can be used to indicate operation speed, and link
status. The LEDs can be programmed to different status functions from
their default value. They can also be controlled directly from the MII
register interface.
So maybe you can control the on/off state.
Andrew
next prev parent reply other threads:[~2016-03-17 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 13:59 [PATCH] Add support to control PHY LEDs Vishal Thanki
2016-03-17 13:59 ` [PATCH] net: phy: at803x: " Vishal Thanki
2016-03-17 14:50 ` Andrew Lunn
2016-03-17 16:59 ` Florian Fainelli
2016-03-17 17:32 ` Vishal Thanki
2016-03-17 17:51 ` Andrew Lunn [this message]
2016-03-17 18:07 ` Vishal Thanki
2016-03-21 17:36 ` Vishal Thanki
2016-03-21 18:13 ` Andrew Lunn
2016-03-17 14:54 ` [PATCH] " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317175152.GG26019@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ujhelyi.m@gmail$(echo .)com \
--cc=vishalthanki@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox