From: Florian Fainelli <f.fainelli@gmail•com>
To: Andrew Lunn <andrew@lunn•ch>, Vishal Thanki <vishalthanki@gmail•com>
Cc: ujhelyi.m@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH] net: phy: at803x: Add support to control PHY LEDs
Date: Thu, 17 Mar 2016 09:59:35 -0700 [thread overview]
Message-ID: <56EAE277.4050109@gmail.com> (raw)
In-Reply-To: <20160317145032.GB26019@lunn.ch>
On 17/03/16 07:50, Andrew Lunn wrote:
> On Thu, Mar 17, 2016 at 02:59:07PM +0100, Vishal Thanki wrote:
>> The LEDs can be turned on and off by a sysfs interface
>> now. Write 0 to "led_enable" file to turn off the LEDs
>> and write 1 to turn on. The support is experimental
>> and can be enabled by kernel configuration option.
>>
>> Signed-off-by: Vishal Thanki <vishalthanki@gmail•com>
>> ---
>> drivers/net/phy/Kconfig | 7 +++++
>> drivers/net/phy/at803x.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++
>
> Hi Vishal
>
> This solution seems specific to the at803. You should be thinking of a
> generic solution that all PHYs can use. eg add a new callback function
> to phy_driver, and put the sysfs handling code in phylib.
Indeed, maybe we should be considering using the existing LEDS subsystem
(drivers/leds/*) to expose the PHY LEDs to user-space in a standard way?
--
Florian
next prev parent reply other threads:[~2016-03-17 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 13:59 [PATCH] Add support to control PHY LEDs Vishal Thanki
2016-03-17 13:59 ` [PATCH] net: phy: at803x: " Vishal Thanki
2016-03-17 14:50 ` Andrew Lunn
2016-03-17 16:59 ` Florian Fainelli [this message]
2016-03-17 17:32 ` Vishal Thanki
2016-03-17 17:51 ` Andrew Lunn
2016-03-17 18:07 ` Vishal Thanki
2016-03-21 17:36 ` Vishal Thanki
2016-03-21 18:13 ` Andrew Lunn
2016-03-17 14:54 ` [PATCH] " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EAE277.4050109@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ujhelyi.m@gmail$(echo .)com \
--cc=vishalthanki@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox